The pref AddPatronLists does not work as expected if 'generic' is selected. Indeed a patron should be linked to a valid patron category (see the constraint borrowers_ibfk_1 in the DB structure).
Created attachment 34817 [details] [review] Bug 13497: Remove the pref AddPatronsLists The pref AddPatronLists does not work as expected if 'generic' is selected. Indeed a patron should be linked to a valid patron category (see the constraint borrowers_ibfk_1 in the DB structure). Test plan: 0/ Confirm that the AddPatronLists does not work as expected if you choose the generic patron types. 1/ Delete all you patron categories and check that the interface invites you to create one. 2/ Confirm that you are able to create a patron and to link it to a patron category you have created.
Does not apply: CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/includes/patron-toolbar.inc Auto-merging installer/data/mysql/updatedatabase.pl CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl
Created attachment 36021 [details] [review] Bug 13497: Remove the pref AddPatronsLists The pref AddPatronLists does not work as expected if 'generic' is selected. Indeed a patron should be linked to a valid patron category (see the constraint borrowers_ibfk_1 in the DB structure). Test plan: 0/ Confirm that the AddPatronLists does not work as expected if you choose the generic patron types. 1/ Delete all you patron categories and check that the interface invites you to create one. 2/ Confirm that you are able to create a patron and to link it to a patron category you have created.
Created attachment 36053 [details] [review] [Signed-off] Bug 13497: Remove the pref AddPatronsLists The pref AddPatronLists does not work as expected if 'generic' is selected. Indeed a patron should be linked to a valid patron category (see the constraint borrowers_ibfk_1 in the DB structure). Test plan: 0/ Confirm that the AddPatronLists does not work as expected if you choose the generic patron types. 1/ Delete all you patron categories and check that the interface invites you to create one. 2/ Confirm that you are able to create a patron and to link it to a patron category you have created. I could not verify step 1/, because at least one Patron category can not be deleted (Staff, since I'm logged in as a Staff patron and you can not delete categories that are in use). Tested 0/ and 2/ Signed-off-by: Marc Véron <veron@veron.ch>
Created attachment 36360 [details] [review] [PASSED QA] Bug 13497: Remove the pref AddPatronsLists The pref AddPatronLists does not work as expected if 'generic' is selected. Indeed a patron should be linked to a valid patron category (see the constraint borrowers_ibfk_1 in the DB structure). Test plan: 0/ Confirm that the AddPatronLists does not work as expected if you choose the generic patron types. 1/ Delete all you patron categories and check that the interface invites you to create one. 2/ Confirm that you are able to create a patron and to link it to a patron category you have created. I could not verify step 1/, because at least one Patron category can not be deleted (Staff, since I'm logged in as a Staff patron and you can not delete categories that are in use). Tested 0/ and 2/ Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes QA script and tests. Current patch-complexity: Small patch
Hi Jonathan, I am happy with the patch, but I am having some doubts if we understand how this was meant to work correctly. Would you mind sending a short email to the Koha mailing list asking people about removing it/a use case where this is needed for?
(In reply to Katrin Fischer from comment #6) > Hi Jonathan, > > I am happy with the patch, but I am having some doubts if we understand how > this was meant to work correctly. Would you mind sending a short email to > the Koha mailing list asking people about removing it/a use case where this > is needed for? I am not sure it's necessary, the pref has been introduced by bug 1782, the default value is categorycode, and it does not work if category_type if defined. Actually I think this pref should have never been created, and it does not make sense since you need to set the borrowers.categorycode with a valid category code.
I guess I am just worried I misunderstood how it should work - looked for other related bugs, but had not much luck.
Created attachment 37755 [details] [review] Bug 13497: Remove the pref AddPatronsLists The pref AddPatronLists does not work as expected if 'generic' is selected. Indeed a patron should be linked to a valid patron category (see the constraint borrowers_ibfk_1 in the DB structure). Test plan: 0/ Confirm that the AddPatronLists does not work as expected if you choose the generic patron types. 1/ Delete all you patron categories and check that the interface invites you to create one. 2/ Confirm that you are able to create a patron and to link it to a patron category you have created. I could not verify step 1/, because at least one Patron category can not be deleted (Staff, since I'm logged in as a Staff patron and you can not delete categories that are in use). Tested 0/ and 2/ Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes QA script and tests.
Created attachment 37758 [details] [review] Bug 13497: (Maniac followup) spell category in english Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
Patch pushed to master. Thanks Jonathan!