The classes Sip::Configuration::Account, Sip::Configuration::Institution and Sip::Configuration::Service are not actually used. Sip::Configuration calls new on all three but does not save the returned objects. Access to accounts, institutions and services is always to the hashref stored in the Configuration object not to objects of these classes. The Config code should be cleaned up by removing these Classes
Created attachment 34858 [details] [review] Proposed patch Removes the unused classes, remove the useless calls to their new methods. Took advantage to remove other obsolete code from configuration Simple Test plan: Select a repeatable series of sip transactions (e.g. an issue and discharge) run before applying patch to confirm all ok, run after applying patch and server should behave identically
Created attachment 35943 [details] [review] Bug 13506: Remove unused Sip/Configuration Classes Sip::Configuration calls new on Account, Institution and Service classes but does not store or subsequently use the returned objects ( which immediately go out of scope ). Their existence just obscures the code and misleads the reader. Remobe them Removed redundant commented out code from Configyration module which was not serving any useful purpose Ran Configuration.pm through perltidy to make layout more consistent Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
There is 1 occurrence of Sip::Configuration::Institution left in C4/SIP/ILS.pod. Maybe should it be removed?
Created attachment 36083 [details] [review] [PASSED QA] Bug 13506: Remove unused Sip/Configuration Classes Sip::Configuration calls new on Account, Institution and Service classes but does not store or subsequently use the returned objects ( which immediately go out of scope ). Their existence just obscures the code and misleads the reader. Remobe them Removed redundant commented out code from Configyration module which was not serving any useful purpose Ran Configuration.pm through perltidy to make layout more consistent Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 36084 [details] [review] Bug 13506 [QA Follouwp] - Fix POD
Patches pushed to master. Thanks Colin!