Whilst working on bug #13499 a number of minor code issues were highlighted by perltidy. I'll collect patches in here to fix various issues
Created attachment 34975 [details] [review] Bug 13521: Removed superflous semicolon Removed an uneeded semicolon from the end of an 'if' block. This should not affect operation of the script. Note: With Bug 13499 we did a non-destructive perltidy, as such we only affected indenting and whitespace to maintain blame history. However, a number of minor code issues were also highlighted, in this series of patches I hope to correct other minor style issues.
Created attachment 34976 [details] [review] Bug 13521: Add missing semicolon Add a missing semicolon to the end of a template variable assignment line. This patch should not affect operation. Note: With Bug 13499 we did a non-destructive perltidy, as such we only affected indenting and whitespace to maintain blame history. However, a number of minor code issues were also highlighted, in this series of patches I hope to correct other minor style issues.
I believe that's all the semicolin issues caught now..
Created attachment 35339 [details] [review] Bug 13521: Removed superflous semicolon Removed an uneeded semicolon from the end of an 'if' block. This should not affect operation of the script. Note: With Bug 13499 we did a non-destructive perltidy, as such we only affected indenting and whitespace to maintain blame history. However, a number of minor code issues were also highlighted, in this series of patches I hope to correct other minor style issues. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Created attachment 35340 [details] [review] Bug 13521: Add missing semicolon Add a missing semicolon to the end of a template variable assignment line. This patch should not affect operation. Note: With Bug 13499 we did a non-destructive perltidy, as such we only affected indenting and whitespace to maintain blame history. However, a number of minor code issues were also highlighted, in this series of patches I hope to correct other minor style issues. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Created attachment 35410 [details] [review] Bug 13521: Removed superflous semicolon Removed an uneeded semicolon from the end of an 'if' block. This should not affect operation of the script. Note: With Bug 13499 we did a non-destructive perltidy, as such we only affected indenting and whitespace to maintain blame history. However, a number of minor code issues were also highlighted, in this series of patches I hope to correct other minor style issues. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Created attachment 35411 [details] [review] Bug 13521: Add missing semicolon Add a missing semicolon to the end of a template variable assignment line. This patch should not affect operation. Note: With Bug 13499 we did a non-destructive perltidy, as such we only affected indenting and whitespace to maintain blame history. However, a number of minor code issues were also highlighted, in this series of patches I hope to correct other minor style issues. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Patches pushed to master. Thanks Martin!
Pushed to 3.18.x will be in 3.18.4
Pushed to 3.16.x, will be in 3.16.10
Pushed to 3.14.x, will be in 3.14.16