Created attachment 34992 [details] [review] Bug 13528: Use the different isbn variations on search on the isbn index (nb) This enhancement adds the ability to search on all isbn variations when searching on the isbn index. Test plan: 0/ Don't apply the patch 1/ Create or choose a notice with an isbn with dashes. 2/ Try to search the notice using the isbn index by it isbn without dashes. => It does not work. 3/ Apply the patch, enable the new pref SearchWithISBNVariations and disable UseQueryParser. 4/ repeat 2 and note that the record is now returned. Note that this only works if UseQueryParser is disabled. It looks like QueryParser does not manage more than 1 operator. See: QueryParser does not manage more than 1 operator? http://lists.koha-community.org/pipermail/koha-devel/2014-December/041028.html and commit 036f2a50e11dab97ef8509f2f585c4cc407ea728 Author: Galen Charlton <gmc@esilibrary.com> Date: Mon May 5 19:31:00 2014 +0000 Bug 10500: (follow-up) disable AggressiveMatchOnISBN if UseQueryParser is on
I am currently working on this but I am having a conflict with the git commit. It should be able to sign off on this soon.
Created attachment 35290 [details] [review] Bug 13528: Use the different isbn variations on search on the isbn index (nb) This enhancement adds the ability to search on all isbn variations when searching on the isbn index. Test plan: 0/ Don't apply the patch 1/ Create or choose a notice with an isbn with dashes. 2/ Try to search the notice using the isbn index by it isbn without dashes. => It does not work. 3/ Apply the patch, enable the new pref SearchWithISBNVariations and disable UseQueryParser. 4/ repeat 2 and note that the record is now returned. Note that this only works if UseQueryParser is disabled. It looks like QueryParser does not manage more than 1 operator. See: QueryParser does not manage more than 1 operator? http://lists.koha-community.org/pipermail/koha-devel/2014-December/041028.html and commit 036f2a50e11dab97ef8509f2f585c4cc407ea728 Author: Galen Charlton <gmc@esilibrary.com> Date: Mon May 5 19:31:00 2014 +0000 Bug 10500: (follow-up) disable AggressiveMatchOnISBN if UseQueryParser is on
(In reply to the.invinnysible.one from comment #2) > I am currently working on this but I am having a conflict with the git > commit. It should be able to sign off on this soon. Thanks! Note that the correct status is "Does not apply".
Created attachment 35316 [details] [review] Bug 13528: Use the different isbn variations on search on the isbn index (nb) This enhancement adds the ability to search on all isbn variations when searching on the isbn index. Test plan: 0/ Don't apply the patch 1/ Create or choose a notice with an isbn with dashes. 2/ Try to search the notice using the isbn index by it isbn without dashes. => It does not work. 3/ Apply the patch, enable the new pref SearchWithISBNVariations and disable UseQueryParser. 4/ repeat 2 and note that the record is now returned. Note that this only works if UseQueryParser is disabled. It looks like QueryParser does not manage more than 1 operator. See: QueryParser does not manage more than 1 operator? http://lists.koha-community.org/pipermail/koha-devel/2014-December/041028.html and commit 036f2a50e11dab97ef8509f2f585c4cc407ea728 Author: Galen Charlton <gmc@esilibrary.com> Date: Mon May 5 19:31:00 2014 +0000 Bug 10500: (follow-up) disable AggressiveMatchOnISBN if UseQueryParser is on Signed-off-by: Morag Hills <the.invinnysible.one@gmail.com>
Bug 13528 - Ability to search on the different isbn variations Signed Off
Created attachment 35335 [details] [review] [PASSED QA] Bug 13528: Use the different isbn variations on search on the isbn index (nb) This enhancement adds the ability to search on all isbn variations when searching on the isbn index. Test plan: 0/ Don't apply the patch 1/ Create or choose a notice with an isbn with dashes. 2/ Try to search the notice using the isbn index by it isbn without dashes. => It does not work. 3/ Apply the patch, enable the new pref SearchWithISBNVariations and disable UseQueryParser. 4/ repeat 2 and note that the record is now returned. Note that this only works if UseQueryParser is disabled. It looks like QueryParser does not manage more than 1 operator. See: QueryParser does not manage more than 1 operator? http://lists.koha-community.org/pipermail/koha-devel/2014-December/041028.html and commit 036f2a50e11dab97ef8509f2f585c4cc407ea728 Author: Galen Charlton <gmc@esilibrary.com> Date: Mon May 5 19:31:00 2014 +0000 Bug 10500: (follow-up) disable AggressiveMatchOnISBN if UseQueryParser is on Signed-off-by: Morag Hills <the.invinnysible.one@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Enhancement pushed. Thanks Jonathan!
(In reply to Kyle M Hall from comment #7) > Created attachment 35335 [details] [review] [review] > [PASSED QA] Bug 13528: Use the different isbn variations on search on the > isbn index (nb) > > This enhancement adds the ability to search on all isbn variations when > searching on the isbn index. > > Test plan: > 0/ Don't apply the patch > 1/ Create or choose a notice with an isbn with dashes. > 2/ Try to search the notice using the isbn index by it isbn without > dashes. > => It does not work. > 3/ Apply the patch, enable the new pref SearchWithISBNVariations and > disable UseQueryParser. > 4/ repeat 2 and note that the record is now returned. > > Note that this only works if UseQueryParser is disabled. > It looks like QueryParser does not manage more than 1 operator. > See: > QueryParser does not manage more than 1 operator? > > http://lists.koha-community.org/pipermail/koha-devel/2014-December/041028. > html > and > commit 036f2a50e11dab97ef8509f2f585c4cc407ea728 > Author: Galen Charlton <gmc@esilibrary.com> > Date: Mon May 5 19:31:00 2014 +0000 > Bug 10500: (follow-up) disable AggressiveMatchOnISBN if > UseQueryParser is on > > Signed-off-by: Morag Hills <the.invinnysible.one@gmail.com> > > Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Hi Kyle, Can you tell me if your improvement also works for research in the acquisition module? acqui/histsearch.pl Regards, Marjorie
*** Bug 16595 has been marked as a duplicate of this bug. ***