The koha-conf.xml template in /etc/ still bears mention of MSWin32 systems. Unless we're ever thinking of suporting windows.. again? We should tidy up this file to remove mention of it.
I will attempt to remove the section in the koha-conf.xml file that mentions this.
Issue existed in koha-conf.xml of /etc. The following lines were removed from the file: <!-- uncomment these lines and comment out the above if running on MSWin32 --> <!-- <listen id="biblioserver" >tcp:localhost:9998/bibliosocket</listen> <listen id="authorityserver" >tcp:localhost:9999/authoritysocket</listen> --> This section was located on lines 9, 10, 11, 12 and 13 of the koha-conf.xml file. Needs sign-off.
Created attachment 35169 [details] [review] Bug 13570 - koha-conf.xml mentions win32 Issue existed in koha-conf.xml of /etc. The following lines were removed from the file: <!-- uncomment these lines and comment out the above if running on MSWin32 --> <!-- <listen id="biblioserver" >tcp:localhost:9998/bibliosocket</listen> <listen id="authorityserver" >tcp:localhost:9999/authoritysocket</listen> --> This section was located on lines 9, 10, 11, 12 and 13 of the koha-conf.xml file.
Created attachment 35173 [details] [review] [SIGNED OFF] Bug 13570 - koha-conf.xml mentions win32 Issue existed in koha-conf.xml of /etc. The following lines were removed from the file: <!-- uncomment these lines and comment out the above if running on MSWin32 --> <!-- <listen id="biblioserver" >tcp:localhost:9998/bibliosocket</listen> <listen id="authorityserver" >tcp:localhost:9999/authoritysocket</listen> --> This section was located on lines 9, 10, 11, 12 and 13 of the koha-conf.xml file. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment on attachment 35173 [details] [review] [SIGNED OFF] Bug 13570 - koha-conf.xml mentions win32 Nice simple patch to tidy up the koha-conf file a little... No negative affects found, singing off. Thanks Morag
Should we remove the bits about Windows from Makefile.PL as well? (git grep MSWin32): Makefile.PL:if ( $^O eq 'MSWin32' ) { ...
Created attachment 35283 [details] [review] [PASSED QA] Bug 13570 - koha-conf.xml mentions win32 Issue existed in koha-conf.xml of /etc. The following lines were removed from the file: <!-- uncomment these lines and comment out the above if running on MSWin32 --> <!-- <listen id="biblioserver" >tcp:localhost:9998/bibliosocket</listen> <listen id="authorityserver" >tcp:localhost:9999/authoritysocket</listen> --> This section was located on lines 9, 10, 11, 12 and 13 of the koha-conf.xml file. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
(In reply to Katrin Fischer from comment #6) > Should we remove the bits about Windows from Makefile.PL as well? (git grep > MSWin32): > Makefile.PL:if ( $^O eq 'MSWin32' ) { > ... Well spotted Katrin.. not sure how I missed those when I spotted these ;).. I'll open another bug for it, save this one going backwards ;)
Patch pushed to master. Thanks Morag!
Pushed to 3.18.x will be in 3.18.3