Same problem as Bug 10943. The page requires borrowers to access but the menu item is still shown to users who do not have the borrowers permission. From readingrec.pl we see: flagsrequired => {borrowers => 1}, Yet in the include the only thing checked is: [% IF ( readingrecordview ) %] So a user who doesn't have permission to access Circulation history can still see the menu item.
I'm working on this.
Created attachment 35263 [details] [review] Bug 13582 - Able to view menu for Circulation History even when user does not have permission Added check for borrowers that stops the Circulation History link being shown. This could be done through the css but that function currently appears to be broke Testing Plan: -Search for a patron with an account that does not have the 'borrowers' permission *Circulation history should not be seen in the menu. -Change the accounts permissions so they have the 'borrowers' permission *Circulation history should be present in the menu.
After discussion with Chris the decision has been made to hide the unnavigable menu items. This could be done with the CSS and greying out the unavailable options but currently that appears to be broken. This may in fact be a better solution as it removes any confusion users may have as to why when they click on things they don't work.
Created attachment 35359 [details] [review] [SIGNED OFF] Bug 13582 - Able to view menu for Circulation History even when user does not have permission Added check for borrowers that stops the Circulation History link being shown. This could be done through the css but that function currently appears to be broken. Testing Plan: -Search for a patron with an account that does not have the 'borrowers' permission *Circulation history should not be seen in the menu. -Change the accounts permissions so they have the 'borrowers' permission *Circulation history should be present in the menu. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Created attachment 35382 [details] [review] Bug 13582 - Able to view menu for Circulation History even when user does not have permission Added check for borrowers that stops the Circulation History link being shown. This could be done through the css but that function currently appears to be broken. Testing Plan: -Search for a patron with an account that does not have the 'borrowers' permission *Circulation history should not be seen in the menu. -Change the accounts permissions so they have the 'borrowers' permission *Circulation history should be present in the menu. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Created attachment 35383 [details] [review] Bug 13582: (follow-up) Able to view menu for Circulation History even when user does not have permission Same changes as the previous patch, for the .tt file.
Patch pushed to master. Thanks Thomas!
Patch pushed to master. Thanks Jonathan!