Same problem as Bug 10943. The page requires borrowers to access but the menu item is still shown to users who do not have the borrowers permission. From statistics.pl we see: flagsrequired => {borrowers => 1}, No permissions are currently checked. So a user who doesn't have permission to access Statistics can still see the menu item.
Working on this.
Created attachment 35266 [details] [review] Bug 13583 - Able to view menu for Statistics even when user does not have permission Added check for borrowers that stops the Statistics link being shown. This could be done through the css but that function currently appears to be broke Testing Plan: -Search for a patron with an account that does not have the 'borrowers' permission *Statistics should not be seen in the menu. -Change the accounts permissions so they have the 'borrowers' permission *Statistics should be present in the menu.
There is also koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.tt but there are many more differences to resolve between both files, so I think this should not be a blocker here.
Created attachment 35352 [details] [review] [SIGNED OFF] Bug 13583 - Able to view menu for Statistics even when user does not have permission Added check for borrowers that stops the Statistics link being shown. This could be done through the css but that function currently appears to be broke Testing Plan: -Search for a patron with an account that does not have the 'borrowers' permission *Statistics should not be seen in the menu. -Change the accounts permissions so they have the 'borrowers' permission *Statistics should be present in the menu. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as described.
Created attachment 35379 [details] [review] Bug 13583 - Able to view menu for Statistics even when user does not have permission Added check for borrowers that stops the Statistics link being shown. This could be done through the css but that function currently appears to be broke Testing Plan: -Search for a patron with an account that does not have the 'borrowers' permission *Statistics should not be seen in the menu. -Change the accounts permissions so they have the 'borrowers' permission *Statistics should be present in the menu. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as described.
Created attachment 35380 [details] [review] Bug 13583: (follow-up) Able to view menu for Statistics even when user does not have permission Same changes as the previous patch, for the .tt file.
Created attachment 35381 [details] [review] Bug 13583: (follow-up) Able to view menu for Statistics even when user does not have permission Same changes as the previous patch, for the .tt file.
Patches pushed to master. Thanks Thomas!