The sample templates in misc/cronjobs/rss have hardcoded urls the should be using suspref OPACBaseURL The contents of rss are rather neglected but many sites seem to want to use this, while most may want some customizations the samples should work out of the box in a sensible fashion at present if you create a list of new acquisitions The links are hardcoded to nz
Created attachment 36762 [details] [review] Proposed patch Simple to test Generating an xml file without the patch (e.g. ./rss.pl ./lastAcquired-1.0.conf ) creates an xhtml page with all the links going to library.org.nz Doing the same with the patch applied and all links should be to the site's own opac as specified in OPACBaseURL
Created attachment 38902 [details] [review] Bug 13591 Pass OPACBaseURL to rss creation process Links in rss templates were hardcoded to library.org.nz. Should pass and use the system's OPACBaseURL. Tested and verified. Signed-off-by: Eivin Giske Skaaren <eskaaren@yahoo.no>
Corrected Eivin's sign off, by obsoleting unsigned version, and marking unsigned. Enjoy QA'ing. :)
Created attachment 38972 [details] [review] [PASSED QA] Bug 13591 Pass OPACBaseURL to rss creation process Links in rss templates were hardcoded to library.org.nz. Should pass and use the system's OPACBaseURL. Tested and verified. Signed-off-by: Eivin Giske Skaaren <eskaaren@yahoo.no> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Patch pushed to master. Good catch Colin!
Pushed to 3.18.x will be in 3.18.7