When RenewalSendNotice is enabled(Send), it isn't reflected in messaging (opac-messaging.pl/moremember.pl). The row marked as "Item checkout" should be updated to "Item checkout/renew". Christopher
Created attachment 110518 [details] [review] Bug 13625: Change messaging preferences descriptions according to RenewalSendNotice Sending out renewal notices depends on the RenewalSendNotice and the patron having the checkout notice checked in their messaging preferences. To test: - Apply patch - Take a look at the messaging preferences table on the following pages: - OPAC > patron account > your messaging tab - Staff interface > patron account > details tab - Staff interface > patron account > edit patron - Toggle the RenewalSendNotice preferences - The label on the last notice should switch between "Item checkout" and "Item checkout and renewal" depending on the pref setting
Created attachment 110523 [details] [review] Bug 13625: Change messaging preferences descriptions according to RenewalSendNotice Sending out renewal notices depends on the RenewalSendNotice and the patron having the checkout notice checked in their messaging preferences. To test: - Apply patch - Take a look at the messaging preferences table on the following pages: - OPAC > patron account > your messaging tab - Staff interface > patron account > details tab - Staff interface > patron account > edit patron - Toggle the RenewalSendNotice preferences - The label on the last notice should switch between "Item checkout" and "Item checkout and renewal" depending on the pref setting Signed-off-by: David Nind <david@davidnind.com>
Created attachment 111556 [details] [review] Bug 13625: Change messaging preferences descriptions according to RenewalSendNotice Sending out renewal notices depends on the RenewalSendNotice and the patron having the checkout notice checked in their messaging preferences. To test: - Apply patch - Take a look at the messaging preferences table on the following pages: - OPAC > patron account > your messaging tab - Staff interface > patron account > details tab - Staff interface > patron account > edit patron - Toggle the RenewalSendNotice preferences - The label on the last notice should switch between "Item checkout" and "Item checkout and renewal" depending on the pref setting Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Trivial improvements, no regressions. Passing QA
Pushed to master for 20.11, thanks to everybody involved!
enhancement will not be backported to 20.05.x