Imagine this scenario: we have one record with four items. Two of those items are checked out, one of those items is a waiting hold, and one of those items is available. We would expect to see this on the search results page. Instead, we will see both non-checked out items as unavailable due to waiting holds. This is due to a semantic issue GetReserveStatus. C4::Search::searchResults uses GetReserveStatus to get the reserve status of each item, but unlike all other calls to the sub, this one passes in not only itemnumber, but biblionumber. When no reserve is found for the available item, the subroutine uses the biblionumber to grab what is essentially an arbitrary reserve to use for the status. This makes no sense and this functionality should be entirely removed from the subroutine so regressions like this will be prevented in the future.
Created attachment 35580 [details] [review] Bug 13636 - Search results item status incorrect for holds Imagine this scenario: we have one record with four items. Two of those items are checked out, one of those items is a waiting hold, and one of those items is available. We would expect to see this on the search results page. Instead, we will see both non-checked out items as unavailable due to waiting holds. This is due to a semantic issue GetReserveStatus. C4::Search::searchResults uses GetReserveStatus to get the reserve status of each item, but unlike all other calls to the sub, this one passes in not only itemnumber, but biblionumber. When no reserve is found for the available item, the subroutine uses the biblionumber to grab what is essentially an arbitrary reserve to use for the status. This makes no sense and this functionality should be entirely removed from the subroutine so regressions like this will be prevented in the future. Test Plan: 1) Create one record with 4 items a) check two of the items out to patrons b) set one of the items as a waiting hold c) leave the fourth item as available 2) Run a search where this record will be in the results list 3) Note that the results list 2 items on loan, two unavailable 4) Apply this patch, reload the search results 5) Note that the results list 1 available, 2 on loan, 1 unavailable
Created attachment 35581 [details] [review] Bug 13636 - Search results item status incorrect for holds Imagine this scenario: we have one record with four items. Two of those items are checked out, one of those items is a waiting hold, and one of those items is available. We would expect to see this on the search results page. Instead, we will see both non-checked out items as unavailable due to waiting holds. This is due to a semantic issue GetReserveStatus. C4::Search::searchResults uses GetReserveStatus to get the reserve status of each item, but unlike all other calls to the sub, this one passes in not only itemnumber, but biblionumber. When no reserve is found for the available item, the subroutine uses the biblionumber to grab what is essentially an arbitrary reserve to use for the status. This makes no sense and this functionality should be entirely removed from the subroutine so regressions like this will be prevented in the future. Test Plan: 1) Create one record with 4 items a) check two of the items out to patrons b) set one of the items as a waiting hold c) leave the fourth item as available 2) Run a search where this record will be in the results list 3) Note that the results list 2 items on loan, two unavailable 4) Apply this patch, reload the search results 5) Note that the results list 1 available, 2 on loan, 1 unavailable
Created attachment 35608 [details] [review] [SIGNED-OFF] Bug 13636 - Search results item status incorrect for holds Imagine this scenario: we have one record with four items. Two of those items are checked out, one of those items is a waiting hold, and one of those items is available. We would expect to see this on the search results page. Instead, we will see both non-checked out items as unavailable due to waiting holds. This is due to a semantic issue GetReserveStatus. C4::Search::searchResults uses GetReserveStatus to get the reserve status of each item, but unlike all other calls to the sub, this one passes in not only itemnumber, but biblionumber. When no reserve is found for the available item, the subroutine uses the biblionumber to grab what is essentially an arbitrary reserve to use for the status. This makes no sense and this functionality should be entirely removed from the subroutine so regressions like this will be prevented in the future. Test Plan: 1) Create one record with 4 items a) check two of the items out to patrons b) set one of the items as a waiting hold c) leave the fourth item as available 2) Run a search where this record will be in the results list 3) Note that the results list 2 items on loan, two unavailable 4) Apply this patch, reload the search results 5) Note that the results list 1 available, 2 on loan, 1 unavailable Signed-off-by: John Andrews <jandrews@washoecounty.us> Signed-off-by: Sheila Kearns <sheila.kearns@state.vt.us>
Created attachment 35730 [details] [review] [PASSED QA] Bug 13636 - Staff search results item status incorrect for holds Imagine this scenario: we have one record with four items. Two of those items are checked out, one of those items is a waiting hold, and one of those items is available. We would expect to see this on the search results page. Instead, we will see both non-checked out items as unavailable due to waiting holds. This is due to a semantic issue GetReserveStatus. C4::Search::searchResults uses GetReserveStatus to get the reserve status of each item, but unlike all other calls to the sub, this one passes in not only itemnumber, but biblionumber. When no reserve is found for the available item, the subroutine uses the biblionumber to grab what is essentially an arbitrary reserve to use for the status. This makes no sense and this functionality should be entirely removed from the subroutine so regressions like this will be prevented in the future. Test Plan: 1) Create one record with 4 items a) check two of the items out to patrons b) set one of the items as a waiting hold c) leave the fourth item as available 2) Run a search where this record will be in the results list 3) Note that the results list 2 items on loan, two unavailable 4) Apply this patch, reload the search results 5) Note that the results list 1 available, 2 on loan, 1 unavailable Signed-off-by: John Andrews <jandrews@washoecounty.us> Signed-off-by: Sheila Kearns <sheila.kearns@state.vt.us> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Note: This is for the staff search result list! Works as expected.
Patch pushed to master. Thanks Kyle!
Pushed to 3.18.x will be in 3.18.4
Possible selection for 3.16.x
Pushed to 3.16.x, will be in 3.16.10