Ran into another problem here - if you leave the password/userid empty on creating a new organisation type patron, you get an error message. Koha should be able to create a userid for organisation patrons (no firstname) too or leave it empty (ILL libraries etc. don't need a login).
Koha should automatically generate a valid username on saving the patron. For organisations this currently fails and you are forced to manually enter a username. To test: - Add a new patron of a patron category marked as 'organisation'. - Enter a name and cardnumber for the patron and try to save. - You will see an error message: The following fields are wrong. Please fix them. Username/password already exists. - Verify you can only save the patron after manually entering a userid.
I realize, it really confuses librarians, raising importance.
Still present when testing with bug 19936. Solution should build on the new code.
Created attachment 74114 [details] [review] Bug 13655: Allow creation of organisations without entering userid See comment 1 of the bug report for defails of the issue. Test plan: Good luck (you will need to test all combinations (category type eq and ne 'I'), then quick edition and partial edit)
Let's try this?
Created attachment 74192 [details] [review] Bug 13655: Allow creation of organisations without entering userid See comment 1 of the bug report for defails of the issue. Test plan: Good luck (you will need to test all combinations (category type eq and ne 'I'), then quick edition and partial edit) Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Appears to works well, marking signed off.
When partially editing an organization patron and clean field username, it is expected the username will be regenerated (as when do full edit, or full and partial edit of normal patron), but the username is leaved unchanged!
I can't reproduce this problem, can you double check? This is what I tried: 1) patch applied, restart all, etc. 2) find a patron with a organisation type category 3) use edit link below 'library use' 4) empty username 5) save 6) username is generated
ping Josef?
Created attachment 76219 [details] Screencast Sorry, for delay. This is what I mean
Created attachment 76239 [details] [review] Bug 13655: Same fix for partial edit Test plan: - Create an organisation with surname='xxx' userid will be autogenerated with 'xxx'' - Edit the surname with 'yyy' userid will be unchanged, 'xxx' - Parial edit and blank userid userid will be autogenerated with 'yyy'
Indeed, thanks Josef!
Created attachment 76250 [details] [review] Bug 13655: Allow creation of organisations without entering userid See comment 1 of the bug report for defails of the issue. Test plan: Good luck (you will need to test all combinations (category type eq and ne 'I'), then quick edition and partial edit) Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 76251 [details] [review] Bug 13655: Same fix for partial edit Test plan: - Create an organisation with surname='xxx' userid will be autogenerated with 'xxx'' - Edit the surname with 'yyy' userid will be unchanged, 'xxx' - Parial edit and blank userid userid will be autogenerated with 'yyy' Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Retested! Josef, can you take another look for QA?
Created attachment 76253 [details] [review] Bug 13655: Allow creation of organisations without entering userid See comment 1 of the bug report for defails of the issue. Test plan: Good luck (you will need to test all combinations (category type eq and ne 'I'), then quick edition and partial edit) Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 76254 [details] [review] Bug 13655: Same fix for partial edit Test plan: - Create an organisation with surname='xxx' userid will be autogenerated with 'xxx'' - Edit the surname with 'yyy' userid will be unchanged, 'xxx' - Parial edit and blank userid userid will be autogenerated with 'yyy' Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Awesome work all! Pushed to master for 18.11.x
Pushed to 18.05.x for 18.05.02
Depends on Bug 19936 not in 17.11.x