If a patron is linked to an organisation, the name of the 'guarantor' is shown on the patron details page in staff. An organisation has no firstname, but the template expects one and adds an extra comma after the name. Example: Garantor: Organisation, To test: - Create 2 patrons, one each for - an organisation type patron category - a member of organisation type patron category - Link both from the 'member patron' edit form - Note that the guarantor is now shown on the details tab - Verify there is an extra comma after the organisation's name
Created attachment 35775 [details] [review] Bug 13657 - Don't show extra comma after guarantor name on patron details Removed second name and comma from template file Testing plan: - Create 2 patrons, one each for - an organisation type patron category - a member of organisation type patron category - Link both from the 'member patron' edit form - Note that the guarantor is now shown on the details tab - Verify there is no extra comma after the organisation's name
Created attachment 35805 [details] [review] Bug 13657 - Don't show extra comma after guarantor name on patron details This patch suppresses the first name part (including comma) if first name is empty. This way, first name is still displays with natural persons, but not with organizations. To test: Apply this patch (without the first patch). Have one patron with a natural person as guarantor and one patron with an organization as guarantor. Verify that both display properly on the patron details page.
Created attachment 36266 [details] [review] Bug 13657 - Don't show extra comma after guarantor name on patron details This patch suppresses the first name part (including comma) if first name is empty. This way, first name is still displays with natural persons, but not with organizations. To test: Apply this patch (without the first patch). Have one patron with a natural person as guarantor and one patron with an organization as guarantor. Verify that both display properly on the patron details page.
Created attachment 36548 [details] [review] [PASSED QA] Bug 13657 - Don't show extra comma after guarantor name on patron details This patch suppresses the first name part (including comma) if first name is empty. This way, first name is still displays with natural persons, but not with organizations. To test: Apply this patch (without the first patch). Have one patron with a natural person as guarantor and one patron with an organization as guarantor. Verify that both display properly on the patron details page. Signed-off-by: Jesse Maseto <Jesse@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Patch pushed to master. Thanks Marc!
Pushed to 3.18.x will be in 3.18.5