All diags should be removed.
Created attachment 38995 [details] [review] Bug 13673: Fix whitespace issues Indentation was horrible. Fixed to meet 4 space standard. TEST PLAN --------- 1) Notice tabs in t/db_dependent/Barcodes.t 2) prove t/db_dependent/Barcodes.t 3) apply patch 4) prove t/db_dependent/Barcodes.t -- same output as before. -- code is identical except for indentations. 5) koha qa test tools
Created attachment 38996 [details] [review] Bug 13673: Fix whitespace issues Indentation was horrible. Fixed to meet 4 space standard. TEST PLAN --------- 1) Notice tabs in t/db_dependent/Barcodes.t 2) $ prove t/db_dependent/Barcodes.t 3) apply patch 4) $ prove t/db_dependent/Barcodes.t -- same output as before. 5) $ git diff -w origin/master -- code is identical except for indentations. 6) koha qa test tools
Created attachment 38997 [details] [review] Bug 13673: Remove diags TEST PLAN --------- 1) Apply first two patches 2) $ prove t/db_dependent/Barcodes.t -- Diags have been removed, just noisy warnings left. 3) $ git diff -w origin/master -- only excess print's and diag's removed. 4) koha qa test tools
Created attachment 38998 [details] [review] Bug 13673: Silence noisy warnings in t/db_dependent/Barcodes.t This last patch catches all the warning messages in tests. TEST PLAN --------- 1) Apply first two patches 2) $ prove t/db_dependent/Barcodes.t -- still noisy warnings. 3) apply last patch 4) $ prove t/db_dependent/Barcodes.t -- All noisy warnings are caught. 5) koha qa test tools.
Created attachment 39000 [details] [review] Bug 13758: (QA followup) revert case change that broke the tests Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
Created attachment 39001 [details] [review] Bug 13673: Remove diags TEST PLAN --------- 1) Apply first two patches 2) $ prove t/db_dependent/Barcodes.t -- Diags have been removed, just noisy warnings left. 3) $ git diff -w origin/master -- only excess print's and diag's removed. 4) koha qa test tools Signed-off-by: Indranil Das Gupta <indradg@gmail.com>
Created attachment 39002 [details] [review] Bug 13673: Remove diags TEST PLAN --------- 1) Apply first two patches 2) $ prove t/db_dependent/Barcodes.t -- Diags have been removed, just noisy warnings left. 3) $ git diff -w origin/master -- only excess print's and diag's removed. 4) koha qa test tools Signed-off-by: Indranil Das Gupta <indradg@gmail.com>
Created attachment 39003 [details] [review] Bug 13673: Fix whitespace issues Indentation was horrible. Fixed to meet 4 space standard. TEST PLAN --------- 1) Notice tabs in t/db_dependent/Barcodes.t 2) $ prove t/db_dependent/Barcodes.t 3) apply patch 4) $ prove t/db_dependent/Barcodes.t -- same output as before. 5) $ git diff -w origin/master -- code is identical except for indentations. 6) koha qa test tools
Created attachment 39004 [details] [review] Bug 13673: Fix whitespace issues Indentation was horrible. Fixed to meet 4 space standard. TEST PLAN --------- 1) Notice tabs in t/db_dependent/Barcodes.t 2) $ prove t/db_dependent/Barcodes.t 3) apply patch 4) $ prove t/db_dependent/Barcodes.t -- same output as before. 5) $ git diff -w origin/master -- code is identical except for indentations. 6) koha qa test tools
Created attachment 39005 [details] [review] Bug 13673: Remove diags TEST PLAN --------- 1) Apply first two patches 2) $ prove t/db_dependent/Barcodes.t -- Diags have been removed, just noisy warnings left. 3) $ git diff -w origin/master -- only excess print's and diag's removed. 4) koha qa test tools Signed-off-by: Indranil Das Gupta <indradg@gmail.com>
Created attachment 39006 [details] [review] Bug 13673: Silence noisy warnings in t/db_dependent/Barcodes.t This last patch catches all the warning messages in tests. TEST PLAN --------- 1) Apply first two patches 2) $ prove t/db_dependent/Barcodes.t -- still noisy warnings. 3) apply last patch 4) $ prove t/db_dependent/Barcodes.t -- All noisy warnings are caught. 5) koha qa test tools.
Created attachment 39010 [details] [review] Bug 13673: Silence noisy warnings in t/db_dependent/Barcodes.t This last patch catches all the warning messages in tests. TEST PLAN --------- 1) Apply first two patches 2) $ prove t/db_dependent/Barcodes.t -- still noisy warnings. 3) apply last patch 4) $ prove t/db_dependent/Barcodes.t -- All noisy warnings are caught. 5) koha qa test tools. Signed-off-by: Indranil Das Gupta <indradg@gmail.com>
Created attachment 39011 [details] [review] Bug 13673: Fix whitespace issues Indentation was horrible. Fixed to meet 4 space standard. TEST PLAN --------- 1) Notice tabs in t/db_dependent/Barcodes.t 2) $ prove t/db_dependent/Barcodes.t 3) apply patch 4) $ prove t/db_dependent/Barcodes.t -- same output as before. 5) $ git diff -w origin/master -- code is identical except for indentations. 6) koha qa test tools Signed-off-by: Indranil Das Gupta <indradg@gmail.com>
Created attachment 39012 [details] [review] Bug 13673: Remove diags TEST PLAN --------- 1) Apply first two patches 2) $ prove t/db_dependent/Barcodes.t -- Diags have been removed, just noisy warnings left. 3) $ git diff -w origin/master -- only excess print's and diag's removed. 4) koha qa test tools Signed-off-by: Indranil Das Gupta <indradg@gmail.com>
Created attachment 39013 [details] [review] Bug 13673: Silence noisy warnings in t/db_dependent/Barcodes.t This last patch catches all the warning messages in tests. TEST PLAN --------- 1) Apply first two patches 2) $ prove t/db_dependent/Barcodes.t -- still noisy warnings. 3) apply last patch 4) $ prove t/db_dependent/Barcodes.t -- All noisy warnings are caught. 5) koha qa test tools. Signed-off-by: Indranil Das Gupta <indradg@gmail.com>
1/ All three test plans were followed. 2/ All three patches cleared koha-qa.pl -c 1 -v 2 without errors.
Created attachment 39220 [details] [review] [PASSED QA] Bug 13673: Fix whitespace issues Indentation was horrible. Fixed to meet 4 space standard. TEST PLAN --------- 1) Notice tabs in t/db_dependent/Barcodes.t 2) $ prove t/db_dependent/Barcodes.t 3) apply patch 4) $ prove t/db_dependent/Barcodes.t -- same output as before. 5) $ git diff -w origin/master -- code is identical except for indentations. 6) koha qa test tools Signed-off-by: Indranil Das Gupta <indradg@gmail.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
Created attachment 39221 [details] [review] [PASSED QA] Bug 13673: Remove diags TEST PLAN --------- 1) Apply first two patches 2) $ prove t/db_dependent/Barcodes.t -- Diags have been removed, just noisy warnings left. 3) $ git diff -w origin/master -- only excess print's and diag's removed. 4) koha qa test tools Signed-off-by: Indranil Das Gupta <indradg@gmail.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
Created attachment 39222 [details] [review] [PASSED QA] Bug 13673: Silence noisy warnings in t/db_dependent/Barcodes.t This last patch catches all the warning messages in tests. TEST PLAN --------- 1) Apply first two patches 2) $ prove t/db_dependent/Barcodes.t -- still noisy warnings. 3) apply last patch 4) $ prove t/db_dependent/Barcodes.t -- All noisy warnings are caught. 5) koha qa test tools. Signed-off-by: Indranil Das Gupta <indradg@gmail.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
Created attachment 39223 [details] [review] Bug 13673: (QA followup) Add license Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
Patches pushed to master. Thanks Mark!