Note that this bug should not appear using the interface. C4::Acquisition::ModReceiveOrder updates the aqorders with budget_id=NULL if no budget_id given in parameter. Actually the same budget_id should be used. In tests (especially t/db_dependent/Acquisition/TransferOrder.t), ModReceiveOrder is not called with a budget_id param and set to NULL the budget_id value.
Created attachment 35708 [details] [review] Bug 13675: Do not set aqorders.budget_id to NULL C4::Acquisition::ModReceiveOrder updates the aqorders with budget_id=NULL if no budget_id given in parameter. Actually the same budget_id should be used. In tests (especially t/db_dependent/Acquisition/TransferOrder.t), ModReceiveOrder is not called with a budget_id param and set to NULL the budget_id value. test plan: prove t/db_dependent/Acquisition/TransferOrder.t should return green Note that this bug should not appear using the interface.
Created attachment 35710 [details] [review] Bug 13675: Do not set aqorders.budget_id to NULL C4::Acquisition::ModReceiveOrder updates the aqorders with budget_id=NULL if no budget_id given in parameter. Actually the same budget_id should be used. In tests (especially t/db_dependent/Acquisition/TransferOrder.t), ModReceiveOrder is not called with a budget_id param and set to NULL the budget_id value. test plan: prove t/db_dependent/Acquisition/TransferOrder.t should return green Note that this bug should not appear using the interface. Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> The fix makes sense, and running $ prove t/db_dependent/Acq* returns all green. koha-qa.pl also likes it.
Created attachment 35732 [details] [review] [PASSED QA] Bug 13675: Do not set aqorders.budget_id to NULL C4::Acquisition::ModReceiveOrder updates the aqorders with budget_id=NULL if no budget_id given in parameter. Actually the same budget_id should be used. In tests (especially t/db_dependent/Acquisition/TransferOrder.t), ModReceiveOrder is not called with a budget_id param and set to NULL the budget_id value. test plan: prove t/db_dependent/Acquisition/TransferOrder.t should return green Note that this bug should not appear using the interface. Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> The fix makes sense, and running $ prove t/db_dependent/Acq* returns all green. koha-qa.pl also likes it. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Patch pushed to master. Thanks Jonathan!
Possible 3.18 candidate, por favor? Can be triggered by locked budgets.
Pushed to 3.18.x, will be in 3.18.12. Leaving pushed to master so it turns up on Chris's radar.
(actually never mind, it's already in 3.20)
Pushed to 3.18.x, is in 3.18.12.