The OpacSuppression preference description is not clear: ... items marked as suppressed from OPAC search results. Note that you must have the <code>Suppress</code> index set up in Zebra and at least one suppressed item, or your searches will be broken. ... The feature works on record level, not on item level.
Created attachment 35812 [details] [review] Bug 13676 - OpacSuppression description says 'items' but means 'records' This patch changes the wording for the OpacSuppression preference description. Without patch: ... items marked as suppressed from OPAC search results. Note that you must have the <code>Suppress</code> index set up in Zebra and at least one suppressed item, or your searches will be broken. ... With patch: ... items marked as suppressed from OPAC search results. Note that you must have the <code>Suppress</code> index set up in Zebra and at least one suppressed biblio record, or your searches will be broken. ...
Created attachment 36133 [details] [review] Bug 13676 - OpacSuppression description says 'items' but means 'records' This patch changes the wording for the OpacSuppression preference description. Without patch: ... items marked as suppressed from OPAC search results. Note that you must have the <code>Suppress</code> index set up in Zebra and at least one suppressed item, or your searches will be broken. ... With patch: ... items marked as suppressed from OPAC search results. Note that you must have the <code>Suppress</code> index set up in Zebra and at least one suppressed biblio record, or your searches will be broken. ... Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
Created attachment 36164 [details] [review] Bug 13676 - OpacSuppression description says 'items' but means 'records' This patch changes the wording for the OpacSuppression preference description. Without patch: ... items marked as suppressed from OPAC search results. Note that you must have the <code>Suppress</code> index set up in Zebra and at least one suppressed item, or your searches will be broken. ... With patch: ... items marked as suppressed from OPAC search results. Note that you must have the <code>Suppress</code> index set up in Zebra and at least one suppressed biblio record, or your searches will be broken. ... Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Patch pushed to master. Thanks Marc!
Pushed to 3.18.x will be in 3.18.5
Contains string changes, holding for 3.16.10
Shouldn't we then change the beginning of the preference description: ___ items marked as suppressed from OPAC search results. should be ___ biblios marked as suppressed from OPAC search results.
I agree with Nicole that this has to be changed in the preference description just the same! (I hope it is okay I didn't file a new bug on this ...)
Created attachment 69862 [details] [review] Bug: 13676: Fixing the OpacSuppression description To Test 1/ Search for OpacSuppression system preference 2/ Notice that it says "Items marked as suppressed from OPAC search results 3/ Noticre also that addresses is spelt wrong 4/ Apply patch 5/ Refresh the page, notice addresses is fixed and items has become biblios
Created attachment 69863 [details] [review] Bug: 13676: Fixing the OpacSuppression description To Test 1/ Search for OpacSuppression system preference 2/ Notice that it says "Items marked as suppressed from OPAC search results 3/ Noticre also that addresses is spelt wrong 4/ Apply patch 5/ Refresh the page, notice addresses is fixed and items has become biblios Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Thx for your first patch Sherryn!
Created attachment 69900 [details] [review] Bug: 13676: Fixing the OpacSuppression description To Test 1/ Search for OpacSuppression system preference 2/ Notice that it says "Items marked as suppressed from OPAC search results 3/ Noticre also that addresses is spelt wrong 4/ Apply patch 5/ Refresh the page, notice addresses is fixed and items has become biblios Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Sherryn, you did not specify your lastname in the commit message, is it expected?
Hi Jonathan It is Mak Thank you
Patch pushed to master for 18.05, congrats Sherryn for your first patch in!