Created attachment 35715 [details] [review] Bug 13679 : Bug in listing overdues To test 1/ Create some overdues and some issues due in the future 2/ Run the overdues script 3/ Notice item due in the future is in the list 4/ Apply patch 5/ Run script again 6/ Notice in the future not in the list
I tried testing but cannot recreate Patron has items due: 2 days ago, yesterday, today, and 2 weeks in future Notice triggers at 1,5 and 10 days Running script with -csv and I only see the two overdues I checked the message queue and see the same there testing on kohadevbox
Did you launch with or without the -t parameter?
(In reply to Jonathan Druart from comment #3) > Did you launch with or without the -t parameter? With -t I only see the item 2 days overdue Without -t I see the items due yesterday and 2 days before.
Nick, Yes actually the test plan is not precis enough. The problem comes from the 3rd overdue, so you need something like: - Notice triggers at 1, 5, 10 days - And items due 1, 2 days ago and 11+ (<90) days in the future.
Created attachment 35986 [details] [review] [SIGNED OFF] Bug 13679 : Bug in listing overdues To test 1/ Create some overdues and some issues due in the future 2/ Run the overdues script 3/ Notice item due in the future is in the list 4/ Apply patch 5/ Run script again 6/ Notice in the future not in the list Signed-off-by: Nick <Nick@quechelibrary.org>
(In reply to Jonathan Druart from comment #5) > Nick, > Yes actually the test plan is not precis enough. > The problem comes from the 3rd overdue, so you need something like: > - Notice triggers at 1, 5, 10 days > - And items due 1, 2 days ago and 11+ (<90) days in the future. Somehow leaving my VM over the weekend and coming back today made it trigger right. :-)
Created attachment 36020 [details] [review] Bug 13679 : Bug in listing overdues To test 1/ Create some overdues and some issues due in the future 2/ Run the overdues script 3/ Notice item due in the future is in the list 4/ Apply patch 5/ Run script again 6/ Notice in the future not in the list Signed-off-by: Nick <Nick@quechelibrary.org> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
I am raising the severity of this bug. I confirm it could affect the -t parameter also. For instance, if you have a trigger at day = X and you have 2 overdue items due at today - X and today + X, both will be marked as late.
Patch pushed to master. Thanks Chrïs!
Pushed to 3.18.x will be in 3.18.4