Bug 13680 - Items list on edit items page separates add items form from header and sidebar
Summary: Items list on edit items page separates add items form from header and sidebar
Status: In Discussion
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
: 23642 (view as bug list)
Depends on:
Blocks:
 
Reported: 2015-02-07 18:39 UTC by Nick Clemens
Modified: 2023-07-27 19:14 UTC (History)
11 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Proposed layout (147.74 KB, image/png)
2015-02-07 18:39 UTC, Nick Clemens
Details
Bug 13680 - Items list on edit items page separates add items form from header and sidebar (7.98 KB, patch)
2015-02-07 18:48 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 13680 - Items list on edit items page separates add items form from header and sidebar (8.04 KB, patch)
2015-02-24 04:55 UTC, Brendan Gallagher
Details | Diff | Splinter Review
Bug 13680 - Make form on edit items page more compact and better readable (1.60 KB, patch)
2015-03-03 16:40 UTC, Marc Véron
Details | Diff | Splinter Review
Bug 13680 - Items list on edit items page separates add items form from header and sidebar (24.73 KB, patch)
2018-05-31 15:11 UTC, Owen Leonard
Details | Diff | Splinter Review
Screenshot showing views as dropdown menu (40.28 KB, image/png)
2018-06-11 15:57 UTC, Owen Leonard
Details
Screenshot showing entry form in modal (56.35 KB, image/png)
2018-06-11 15:58 UTC, Owen Leonard
Details
Screenshot showing alternate view menu (37.70 KB, image/png)
2018-12-06 19:41 UTC, Owen Leonard
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Clemens 2015-02-07 18:39:20 UTC
Created attachment 35720 [details]
Proposed layout

On records with multiple items attached the add items form can be pushed down the page, separating it from the header and sidebar and requiring a choice between where pages focus should fall and often leading to scrolling depending on your action. See bug 11905

A different solution would be to move the existing items list to the bottom of the page.

This is a fairly striking difference, but with the addition of edit item links on the record detail page I don't think it makes selecting an item to edit more onerous.  That being said, change is upsetting and I believe this would need some discussion.
Comment 1 Nick Clemens 2015-02-07 18:48:13 UTC Comment hidden (obsolete)
Comment 2 Brendan Gallagher 2015-02-24 04:55:38 UTC
Created attachment 36128 [details] [review]
Bug 13680 - Items list on edit items page separates add items form from header and sidebar

This patch moves the items table on the edit items screen to the bottom of the page.

Test plan:
1 - Apply patch
2 - Ensure adding/editing items works as previously

Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>

I like this idea a lot.  I think if everyone gave it a shot and got used to the work flow then everyone would love it.
Comment 3 Jonathan Druart 2015-02-25 11:44:09 UTC
Comment on attachment 36128 [details] [review]
Bug 13680 - Items list on edit items page separates add items form from header and sidebar

Review of attachment 36128 [details] [review]:
-----------------------------------------------------------------

::: koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt
@@ +134,4 @@
>  
>     <div id="bd">
>  	<div id="yui-main">
> +<h1>Add items to [% title |html %] [% IF ( author ) %] by [% author %][% END %] (Record #[% biblionumber %])</h1>

Not sure this change is consistent:
If you edit an item, you see:

  Add items to my_bib
  Edit Item #23192

There is Add vs Edit on the same page.

Maybe it is better to keep the original wording here, don't you think?
Comment 4 Nick Clemens 2015-02-25 23:21:39 UTC
Yeah, see your point, my only thought was it might seem odd to say "Items for TITLE_OF_BIB"  when the items are not listed immediately.  'why I added the "Existing items for TITLE_OF_BIB" above the item list

I am happy to keeping the wording as is, but maybe would prefer either: 
1 - "Edit items for TITLE_OF_BIB" 
2 - "TITLE_OF_BIB" and let the "Add item/Edit item #" indicate the current action
Comment 5 Katrin Fischer 2015-03-03 14:14:43 UTC
I am not sure yet if I am just 'ew change!' or if it's something else that bothers me. Still turning this around in my head, not feeling quite ready to pass QA. 

I'd like to get some more eyes on this.
Comment 6 Marc Véron 2015-03-03 16:39:03 UTC
I played around with the orignil an d the new version. My conclusion is that the new version (item list on bottom of the page) would be better.

CSS patch follows as a proposition for formatting the form a little bit to make it more compact and better readable.
Comment 7 Marc Véron 2015-03-03 16:40:02 UTC
Created attachment 36425 [details] [review]
Bug 13680 - Make form on edit items page more compact and better readable

This patch makes the form on the edit items page more compact by decreasing the label font and indenting properly if a laberl has multiple rows. Additionally, a thin white line helps the eye to connect a label with the appropriate field.

It is just a proposition regardless whether the form will be displayed above or below the items table.
Comment 8 Christopher Brannon 2015-04-09 21:40:20 UTC
I know it is a little late in the game, but just to stir up the pot a bit, what if the list was collapsed during edit?  Show only the record being edited, and all other items are in an expandable list?  The list would be expanded when not editing, and contracts during edit.

The plus to this is you get to see the line, and there is less scrolling.  

Frankly, I don't think the edit screen should always be open.  I think it leads to confusion as to whether you've got something new or editing something from the list.  I would go as far as collapsing the edit list when not in use, or making it modal.  Just my added two cents.

Thoughts?
Comment 9 Katrin Fischer 2015-04-09 21:43:49 UTC
Hi Christopher, I had similar thoughts at this +1 for your suggestions.
Comment 10 Kyle M Hall 2015-07-23 14:04:55 UTC
(In reply to Christopher Brannon from comment #8)
> I know it is a little late in the game, but just to stir up the pot a bit,
> what if the list was collapsed during edit?  Show only the record being
> edited, and all other items are in an expandable list?  The list would be
> expanded when not editing, and contracts during edit.
> 
> The plus to this is you get to see the line, and there is less scrolling.  
> 
> Frankly, I don't think the edit screen should always be open.  I think it
> leads to confusion as to whether you've got something new or editing
> something from the list.  I would go as far as collapsing the edit list when
> not in use, or making it modal.  Just my added two cents.
> 
> Thoughts?

+1 for modal!
Comment 11 Owen Leonard 2018-05-31 15:11:05 UTC
Created attachment 75706 [details] [review]
Bug 13680 - Items list on edit items page separates add items form from header and sidebar

This is a proof of concept patch showing how I would improve this
interface with a modal window for the item add form. The "views" menu is
converted to a button menu. That goes against interface guidelines, but
I don't see how else to handle it without taking up valuable screen real
estate.

This patch isn't complete--it doesn't handle edit operations. I just
wanted to show the layout changes and how the "Add" button triggers the
modal.

Feeback welcome.
Comment 12 Owen Leonard 2018-06-11 15:57:56 UTC
Created attachment 75964 [details]
Screenshot showing views as dropdown menu
Comment 13 Owen Leonard 2018-06-11 15:58:20 UTC
Created attachment 75965 [details]
Screenshot showing entry form in modal
Comment 14 Christopher Brannon 2018-06-11 16:37:01 UTC
I love it!  I'm not a cataloger, but I think it is a MASSIVE improvement as a modal.  I would definitely go that direction.  I also like the changes with View.
Comment 15 Katrin Fischer 2018-06-12 05:20:08 UTC
I like the modal, but not sure about the views in the menu. I often get asked in training on how to get to see the record after cataloguing and always point out the normal tab as the quickest option. This would add an extra click and make it less prominent.
Comment 16 Heather 2018-06-19 21:23:19 UTC
I'm just looking at this for the first time, and I am a cataloger.:)  I would love ANYTHING that gets me away from scrolling down through 200+ items to add an item!!!

I can live with the modal--I often copy from an existing item in the table & paste into the new item, and with the model I'd simply do that from another browser tab, easy-peasy.

My dream is that the "Actions" buttons (on the items in the item table) would have a "Duplicate" action that would allow me to clone an item that duplicated that item exactly except for $d and $p and I could then add a new barcode, edit the $h and/or $t and be done.  Until then, this modal add item is a HUGE improvement.  (Now, if I could get that "Duplicate" in the "Actions" button and launch that new item modal like this, I'd be living the dream!)

I like the "View" button.  I'm most often going directly from item editing to bib record editing (with Advanced Editor/Rancor), so don't mind one more click to get to "Normal."  (I edit items first then go to Rancor because starting with Rancor then "Edit items" opens editing the items another tab, which I find annoying--I'd prefer it staying in the same tab.)
Comment 17 Owen Leonard 2018-12-06 19:41:13 UTC
Created attachment 82942 [details]
Screenshot showing alternate view menu

What about this version of the view menu?
Comment 18 Heather 2018-12-06 21:37:10 UTC
Ooooooh, Owen, I'm loving it!!  And "MARC" vs. "Labeled MARC" is sweeeeeeeeet!!!  This would make me a very happy cataloger!  I'd like it now, please.

--h2
Comment 19 Christopher Brannon 2018-12-06 22:52:02 UTC
Can the tabs be included in a dropdown on the edit modal?  Should they be?
Comment 20 Owen Leonard 2018-12-07 12:45:46 UTC
(In reply to Christopher Brannon from comment #19)
> Can the tabs be included in a dropdown on the edit modal?  Should they be?

I wouldn't think that someone in the process of adding or editing an item would want to leave what they were doing to look at the record.
Comment 21 Heather 2018-12-07 16:30:18 UTC
> I wouldn't think that someone in the process of adding or editing an item would > want to leave what they were doing to look at the record.

This is correct for my workflow--it is extremely rare that I want to look back at the bib while editing/adding item(s), and in that rare case, I'll open the bib up in a different tab (or window) to preserved where I am in the item editing/adding workflow.  I've usually done all the bib record examination that I need to do before editing/adding item(s).  Usually.  Ideally.:)

--h2
Comment 22 Owen Leonard 2019-09-20 11:54:50 UTC
*** Bug 23642 has been marked as a duplicate of this bug. ***
Comment 23 Christopher Brannon 2019-09-20 14:25:58 UTC
I definitely feel the modal and alternate view are the ways to go.  Putting the table at the bottom would just disrupt the flow.  I'm trying to get others to give input on this, but I think this is the direction we should move in.
Comment 24 Kelly McElligott 2023-07-27 00:31:09 UTC
This came up with a library recently.  When adding an item to a record with over 50 items this is a lot of scrolling, but imagine a library with 200 items, massive amount of scrolling.  I would love to see this move forward at this point .  A collapsed option of all the items, and the ability to uncollapse? Owen's attachments are a definite improvement to what we are working with now.
Comment 25 Christopher Brannon 2023-07-27 19:14:17 UTC
(In reply to Kelly McElligott from comment #24)
> This came up with a library recently.  When adding an item to a record with
> over 50 items this is a lot of scrolling, but imagine a library with 200
> items, massive amount of scrolling.  I would love to see this move forward
> at this point .  A collapsed option of all the items, and the ability to
> uncollapse? Owen's attachments are a definite improvement to what we are
> working with now.

+1