Today it's possible to define your own alphabet in the I18N/L10N preferences. This shows up in members-home.pl and lets you browse patrons. If you define an alphabet outside of the A-Z comfort zone (as in swedish with additional characters Å,Ä,Ö at the end) then the browsing will mix together for example Å,Ä,A and only view the additional letters as diacritics. A quick solution is to change the collation in the database but there is nothing in the syspref explaining this. My ambition here is to give users a quick hint that this can be done.
Created attachment 35778 [details] [review] Bug 13686 Add a hint about collation to the "alphabet" syspref This patch adds a quick hint in the "alphabet" syspref about the use of collation in the database to make browsing by surname work with alphabets outside of the A-Z range. Test plan: * Look at the "alphabet" syspref. * Install the patch and verify that the additional info about the use of collation is showing up in the "alphabet" syspref.
Hi Viktor, The text does not display at all, only the form field is visible. Reason: The text contains a colon (:), that breaks the display. Solution: Put the text in quotes. Marc
Created attachment 35817 [details] [review] Bug 13686 Add a hint about collation to the alphabet syspref This patch adds a quick hint in the "alphabet" syspref about the use of collation in the database to make browsing by surname work with alphabets outside of the A-Z range. Test plan: * Look at the "alphabet" syspref. * Install the patch and verify that the additional info about the use of collation is showing up in the "alphabet" syspref. This patch is hopefully also working - thanks Marc! Guess it goes to prove that no patch is too small to test properly before posting.
I also learned not to put anything outside of A-Z in the commit messages. Had to learn how to use --amend in git :)
Hi Viktor, You can put qoutes around the whole text and leave the colon (:) in it: - "for lists of browsable letters. This should be a space separated list of uppercase letters. Hint: Changing collation in the database for the surname column of members is helpful to make browsing by last name work in members-home.pl when using an alphabet outside of A-Z."
Created attachment 35821 [details] [review] Bug 13686 Add a hint about collation to the alphabet syspref This patch adds a quick hint in the "alphabet" syspref about the use of collation in the database to make browsing by surname work with alphabets outside of the A-Z range. Test plan: * Look at the "alphabet" syspref. * Install the patch and verify that the additional info about the use of collation is showing up in the "alphabet" syspref. Third times a charm hopefully :) This patch reintroduces the colon in "Hint:" and also corrects a weird wordning. Thanks Marc!
Hi Viktor, This patch seems to be on top of the first (obsoleted) patch and does not apply. I think the best way to resolve is to obsolete this latest patch and reactivate the very first patch. Then add the double quotes, do git add for the changed file and then do git commit --amend
Created attachment 35825 [details] [review] Bug 13686 Add a hint about collation to the alphabet syspref This patch adds a quick hint in the "alphabet" syspref about the use of collation in the database to make browsing by surname work with alphabets outside of the A-Z range. Test plan: * Look at the "alphabet" syspref. * Install the patch and verify that the additional info about the use of collation is showing up in the "alphabet" syspref. Trying to follow Marcs instructions on how to wrestle Git into posting the corrected patch. Fingers crossed..
Hm. When applying the patch on a new branch with git bz after having marked the first one as active and run --amend it still wants to apply both patches. Using interactive mode I tried to get attachment 35825 [details] [review] but that only messed up things with markup code in the .pref file. Will try to deactivate the first one again and hopefully leave 35825 applicable.
No patches to sign off at the moment. Viktor: Maybe do a new patch from scratch? :-)
Created attachment 35956 [details] [review] Bug 13686 Add a hint about collation to the alphabet syspref New attempt from a fresh branch. Test plan: * Look at the alphabet syspref. * Install the patch. * Look again at the alphabet syspref and you should see a short hint about collation. Thanks for the patience - I already learned a few new things about Git with this patch.
Ok - new attempt from a new branch after cleaning out my entire local Git. I don't have very high hopes, but it looks ok and seem to apply without complaints now. Fingers crossed and thanks for the patience.
Created attachment 35958 [details] [review] [Signed-off] Bug 13686 Add a hint about collation to the alphabet syspref New attempt from a fresh branch. Test plan: * Look at the alphabet syspref. * Install the patch. * Look again at the alphabet syspref and you should see a short hint about collation. Thanks for the patience - I already learned a few new things about Git with this patch. Text appears as expected. Signed-off-by: Marc Véron <veron@veron.ch>
Created attachment 36038 [details] [review] Bug 13686 Add a hint about collation to the alphabet syspref New attempt from a fresh branch. Test plan: * Look at the alphabet syspref. * Install the patch. * Look again at the alphabet syspref and you should see a short hint about collation. Thanks for the patience - I already learned a few new things about Git with this patch. Text appears as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Amended patch: add a br tag
oleonard: Joubu: I suggest "Changing collation in the database for the 'surname' column of the 'borrowers' table is helpful to make browsing by last name work in members-home.pl when using an alphabet outside of A-Z" oleonard: I don't like referring to "members-home.pl" but I don't know a better way to say it.
Created attachment 36040 [details] [review] Bug 13686: Change wording Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Patches pushed to master. Thanks Viktor!
Pushed to 3.18.x will be in 3.18.6