While coding RSS for news in Opac the need for a unique link to each item in the news became clear. A quick fix that still doesn't clash with later adding a single newsitem view is to give news in Opac a unique anchor for linking purposes.
Created attachment 36007 [details] [review] Bug 13729 Give news in Opac a unique anchor This patch introduces the use of the idnew-value from the opac_news table as a base for a unique anchor on each newsitem in Opac. The anchor can be used for linking to specific newsitems and also for improving bug 7843 (RSS stream for news) with a unique link to each item in the RSS stream. Test plan: * Make shure you have a few news in the opac. Best is if it's enough to hide a few beneath the bottom of the window. * Install the patch. * Verify that you can access newitems with links like mykoha/cgi-bin/koha/opac-main.pl#newsitem4 * Experiment with removing newsitems and verify that that the newsitem-id stay unique to each newsitem.
Created attachment 36009 [details] [review] Bug 13729 - [SIGNED-OFF] Give news in Opac a unique anchor This patch introduces the use of the idnew-value from the opac_news table as a base for a unique anchor on each newsitem in Opac. The anchor can be used for linking to specific newsitems and also for improving bug 7843 (RSS stream for news) with a unique link to each item in the RSS stream. Test plan: * Make shure you have a few news in the opac. Best is if it's enough to hide a few beneath the bottom of the window. * Install the patch. * Verify that you can access newitems with links like mykoha/cgi-bin/koha/opac-main.pl#newsitem4 * Experiment with removing newsitems and verify that that the newsitem-id stay unique to each newsitem. Signed-off-by: Magnus Enger <magnus@enger.priv.no> Works as advertised. Nice enhancement!
Created attachment 36026 [details] [review] Bug 13729 - Give news in Opac a unique anchor This patch introduces the use of the idnew-value from the opac_news table as a base for a unique anchor on each newsitem in Opac. The anchor can be used for linking to specific newsitems and also for improving bug 7843 (RSS stream for news) with a unique link to each item in the RSS stream. Test plan: * Make shure you have a few news in the opac. Best is if it's enough to hide a few beneath the bottom of the window. * Install the patch. * Verify that you can access newitems with links like mykoha/cgi-bin/koha/opac-main.pl#newsitem4 * Experiment with removing newsitems and verify that that the newsitem-id stay unique to each newsitem. Signed-off-by: Magnus Enger <magnus@enger.priv.no> Works as advertised. Nice enhancement! Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Patch pushed to master. Thanks Viktor!
Always fun to get something pushed. Thanks :)
Pushed to 3.18.x will be in 3.18.5
Pushed to 3.16.x, will be in 3.16.8