When creating a new subscription, check 'manual history' and put text into the internal and public note fields. After saving, the notes are not only saved to the normal note fields, but also copied to the subscription history. After initial creation of the subscription, the notes fields behave normally and are saved to the correct fields in the database when edited.
Database fields are: Subscription subscription.notes (public) subscription.internalnotes (internal) Subscription history subscriptionhistory.opacnote (public) subscripitonhistory.librariannote (internal)
Created attachment 36116 [details] [review] Bug 13746: On creating a new subscription, notes fields get confused For every subscription we have 4 notes fields in Koha, 2 are in the subscription itself and another 2 are in the subscription history. When creating a new subscription, the notes fields from the subscription get copied to the fields of the subscription history, leading to doubled up display of notes in the OPAC. To test: - Add a new subscription without patch - check manual history - Fill in both notes fields - Verify that the notes fields got also saved into the subscription history (easy from the Summary tab) - Apply patch - Add another subscription, like above - Verify now only the subscription notes fields are saved - Edit subscription and notes - verify all is ok - Edit subscription history (Planning tab) - verify all is ok
All existing tests pass with the change. Not sure about new unit tests - could someone suggest what would be good to test here?
Katrin - I feel like I've seen this before but described a little bit differently. I am looking for a similar bug (I haven't found it yet). I think I've seen language like - manual history fails. (no comment for new direction on the unit tests). If I do not find a similar bug then I'll be glad to test this. Of course any enlightenment for me is always welcome. Cheers, Brendan
Hi Brendan, this is just for the note fields - the less complicated part of the self-updating history. I have seen some other things while testing in the issue related fields, but haven't looked into it yet.
Created attachment 36126 [details] [review] Bug 13746: On creating a new subscription, notes fields get confused For every subscription we have 4 notes fields in Koha, 2 are in the subscription itself and another 2 are in the subscription history. When creating a new subscription, the notes fields from the subscription get copied to the fields of the subscription history, leading to doubled up display of notes in the OPAC. To test: - Add a new subscription without patch - check manual history - Fill in both notes fields - Verify that the notes fields got also saved into the subscription history (easy from the Summary tab) - Apply patch - Add another subscription, like above - Verify now only the subscription notes fields are saved - Edit subscription and notes - verify all is ok - Edit subscription history (Planning tab) - verify all is ok Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
Created attachment 36165 [details] [review] Bug 13746: On creating a new subscription, notes fields get confused For every subscription we have 4 notes fields in Koha, 2 are in the subscription itself and another 2 are in the subscription history. When creating a new subscription, the notes fields from the subscription get copied to the fields of the subscription history, leading to doubled up display of notes in the OPAC. To test: - Add a new subscription without patch - check manual history - Fill in both notes fields - Verify that the notes fields got also saved into the subscription history (easy from the Summary tab) - Apply patch - Add another subscription, like above - Verify now only the subscription notes fields are saved - Edit subscription and notes - verify all is ok - Edit subscription history (Planning tab) - verify all is ok Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Created attachment 36166 [details] [review] Bug 13746: Add tests Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Patches pushed to master. Thanks Katrina and Jonathan!
Pushed to 3.18.x will be in 3.18.5
Pushed to 3.16.x, will be in 3.16.10