Under Reports > Acquisition wizard appear 2 untranslatable strings in the pull downs: - All item types - All funds
"All item types ": See reports/acquisitions/stats.pl line 128 "All funds": See line 147 Additionally, 'Collection code' seems not to be translated (first column), it is related to a variable $ccode_lable that is set in reports/acquisitions/stats.pl line 237, and this variable depends on GetMarcSubfieldsStructureFromKohaField (C4/Bilio.pm)
Created attachment 36768 [details] [review] Bug 13748: Acquisition wizard: some strings not translatable This patch removes all instances of CGI::scrolling_list from reports/acquisitions_stats.pl, which prevented proper translation To test: 1) Install and enable a language (es-ES or de-DE are good choices) 2) On Acquisitons wizard, some pulldown labels are not translated 3) Apply the patch 4) Update and install again the language 5) Check labels are translated and all pulldown works This does not solve the 'Collection code' problem, is more strange
Created attachment 36769 [details] [review] Bug 13748: Acquisition wizard: some strings not translatable This patch removes all instances of CGI::scrolling_list from reports/acquisitions_stats.pl, which prevented proper translation To test: 1) Install and enable a language (es-ES or de-DE are good choices) 2) On Acquisitons wizard, some pulldown labels are not translated 3) Apply the patch 4) Update and install again the language 5) Check labels are translated and all pulldown works This does not solve the 'Collection code' problem, is more strange
Created attachment 36775 [details] [review] [Signed-off] Bug 13748: Acquisition wizard: some strings not translatable This patch removes all instances of CGI::scrolling_list from reports/acquisitions_stats.pl, which prevented proper translation To test: 1) Install and enable a language (es-ES or de-DE are good choices) 2) On Acquisitons wizard, some pulldown labels are not translated 3) Apply the patch 4) Update and install again the language 5) Check labels are translated and all pulldown works This does not solve the 'Collection code' problem, is more strange Followed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch>
Created attachment 36904 [details] [review] [PASSED QA] Bug 13748: Acquisition wizard: some strings not translatable This patch removes all instances of CGI::scrolling_list from reports/acquisitions_stats.pl, which prevented proper translation To test: 1) Install and enable a language (es-ES or de-DE are good choices) 2) On Acquisitons wizard, some pulldown labels are not translated 3) Apply the patch 4) Update and install again the language 5) Check labels are translated and all pulldown works This does not solve the 'Collection code' problem, is more strange Followed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as described, good improvement.
Patch pushed to master. Thanks Bernardo!
Pushed to 3.18.x will be in 3.18.6