Created attachment 36376 [details] Screenshot of the table In the relatives' checkouts table one column heading is missing, so most of the column headings are off and don't match what is shown in the column. It looks like the very first column heading for 'due date' is missing.
Created attachment 42396 [details] [review] CAM 2146 - Bug 13781 - Fix relatives's checkouts missing heading columns There was two missing heading columns (location and fine) and one hidden heading missing column (this hidden column is needing for sorting the table) it was taking the due_date column for the hidden column, so I added them
Created attachment 42459 [details] [review] CAM 2146 - Bug 13781 - Fix missing heading columns for relative's checkouts table in check out patron page Theres was two missing heading columns Location and Fines in the Check out section of a Patron
Created attachment 42460 [details] [review] CAM 2146 - Bug 13781 - Fix relatives's checkouts missing heading columns There was two missing heading columns (location and fine) and one hidden heading missing column (this hidden column is needing for sorting the table) it was taking the due_date column for the hidden column, so I added them Both patches tested together. Works as expected. Signed-off-by: Marc Véron <veron@veron.ch>
Created attachment 42461 [details] [review] CAM 2146 - Bug 13781 - Fix missing heading columns for relative's checkouts table in check out patron page Theres was two missing heading columns Location and Fines in the Check out section of a Patron Tested both patches together. Works as expected. Signed-off-by: Marc Véron <veron@veron.ch>
Please make sure to include a test plan in your commit messages in the future.
There are also 2 other small things to keep an eye on next time: 1) Please start your commit messages with Bug xxxxx: - that will help our release scripts and other tools pick them up correctly. 2) Please be careful - Koha standardized to using 4 spaces and no tabs. The QA tool pointed out some issues there that I have fixed when reviewing your patches: FAIL koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt FAIL forbidden patterns forbidden pattern: tab char (line 896) forbidden pattern: tab char (line 900) OK spelling OK tt_valid OK valid_template FAIL koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt FAIL forbidden patterns forbidden pattern: tab char (line 451) forbidden pattern: tab char (line 447) forbidden pattern: tab char (line 456) OK spelling OK tt_valid OK valid_template
Created attachment 42501 [details] [review] [PASSED QA] Bug 13781: Fix relatives's checkouts missing heading columns There was two missing heading columns (location and fine) and one hidden heading missing column (this hidden column is needing for sorting the table) it was taking the due_date column for the hidden column, so I added them Both patches tested together. Works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 42502 [details] [review] [PASSED QA] Bug 13781: Fix missing heading columns for relative's checkouts table in check out patron page Theres was two missing heading columns Location and Fines in the Check out section of a Patron Tested both patches together. Works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Thx for fixing this :)
Ok I'm sorry and thank you, I'll be careful next time ^^
Patches pushed to master. Thanks Genevieve and congrats for your first commits to Koha!
Pushed to 3.20.x will be in 3.20.4
Pushed to 3.18.x will be in 3.18.11