Patch to come.
Created attachment 36413 [details] [review] Bug 13785 - Koha-disable should also stop SIP and zebra for instance Currently koha-disable ONLY disables the instance in the apache conf file. Presumably if you want to disable the instance, you also want its processes to stop, so this patch will stop zebra, if running, and SIP, if enabled. Depends on Bug 13784. To Test: 1) Have an enabled instance, with zebra and SIP running. 2) Run koha-disable INST. Note that after, both zebra and SIP will still be running. 3) Re-enable INST. 4) Apply patch, and then copy debian/scripts/koha-disable to package site, over /usr/sbin/koha-disable. 5) Run koha-disable INST. You should now see that both zebra and SIP have been stopped.
Created attachment 36509 [details] [review] Bug 13785 - Koha-disable should also stop SIP and zebra for instance Currently koha-disable ONLY disables the instance in the apache conf file. Presumably if you want to disable the instance, you also want its processes to stop, so this patch will stop zebra, if running, and SIP, if enabled. Depends on Bug 13784. To Test: 1) Have an enabled instance, with zebra and SIP running. 2) Run koha-disable INST. Note that after, both zebra and SIP will still be running. 3) Re-enable INST. 4) Apply patch, and then copy debian/scripts/koha-disable to package site, over /usr/sbin/koha-disable. 5) Run koha-disable INST. You should now see that both zebra and SIP have been stopped. Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net>
Created attachment 36518 [details] [review] Bug 13785 - Koha-disable should also stop SIP and zebra for instance Currently koha-disable ONLY disables the instance in the apache conf file. Presumably if you want to disable the instance, you also want its processes to stop, so this patch will stop zebra, if running, and SIP, if enabled. Depends on Bug 13784. To Test: 1) Have an enabled instance, with zebra and SIP running. 2) Run koha-disable INST. Note that after, both zebra and SIP will still be running. 3) Re-enable INST. 4) Apply patch, and then copy debian/scripts/koha-disable to package site, over /usr/sbin/koha-disable. 5) Run koha-disable INST. You should now see that both zebra and SIP have been stopped. Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> Signed-off-by: Robin Sheat <robin@catalyst.net.nz>
Created attachment 36519 [details] [review] Bug 13785 - Koha-disable should also stop SIP and zebra for instance Currently koha-disable ONLY disables the instance in the apache conf file. Presumably if you want to disable the instance, you also want its processes to stop, so this patch will stop zebra, if running, and SIP, if enabled. Depends on Bug 13784. To Test: 1) Have an enabled instance, with zebra and SIP running. 2) Run koha-disable INST. Note that after, both zebra and SIP will still be running. 3) Re-enable INST. 4) Apply patch, and then copy debian/scripts/koha-disable to package site, over /usr/sbin/koha-disable. 5) Run koha-disable INST. You should now see that both zebra and SIP have been stopped. Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> Signed-off-by: Robin Sheat <robin@catalyst.net.nz>
Created attachment 36731 [details] [review] Bug 13785: koha-disable should also stop SIP and zebra for instance Currently koha-disable ONLY disables the instance in the apache conf file. Presumably if you want to disable the instance, you also want its processes to stop, so this patch will stop zebra, if running, and SIP, if enabled. Depends on Bug 13784. To Test: 1) Have an enabled instance, with zebra and SIP running. 2) Run koha-disable INST. Note that after, both zebra and SIP will still be running. 3) Re-enable INST. 4) Apply patch, and then copy debian/scripts/koha-disable to package site, over /usr/sbin/koha-disable. 5) Run koha-disable INST. You should now see that both zebra and SIP have been stopped. Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> Signed-off-by: Robin Sheat <robin@catalyst.net.nz> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
Created attachment 36732 [details] [review] Bug 13785: (QA followup) koha-disable should stop the indexer daemon Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
Patch pushed to master. Thanks Larry!
Pushed to 3.18.x will be in 3.18.5
Pushed to 3.16.x, will be in 3.16.9