Could a patron see an alert when renewing their items via My Account on the OPAC if the item has a rental fee associated with it? This would be very useful as then the patron could decide whether or not they wish to go ahead with the renewal. So for example, they have borrowed a DVD and already paid £2.50 at the time of checking the item out. If they renew this DVD then they are automatically charged another £2.50 but currently there is no alert at the point of renewing in the opac to tell them this.
As well valid for current master?
Created attachment 52657 [details] [review] Bug 13796: OPAC: Display rental charge for renewing This patch displays the rental fee that will be applied for renewing (near "Renew" link on patron's summary page) To test: - Apply patch - Verify that you have item types with and without rental fee for testing - Issue items with an without rental fee to a patron - In OPAC, display patron's summary page - Verify in table 'Checked out', items with rental charge display an information as appropriate (near the link 'Renew')
Hi Marc, This is great, and definitely works - but on the sandbox I used, [% ISSUE.description %] didn't call anything back, which led to this rather confusing description on the renewal screen: Renew Fee for 5.00 (4 of 5 renewals remaining) Could: <span class="renewalfee">Fee for [% ISSUE.description %] [% ISSUE.renewalfee | $Price %]</span> be altered slightly to say something like: <span class="renewalfee">NOTE: A charge of [% ISSUE.renewalfee | $Price %] will be added.</span> which would generate: Renew NOTE: A charge of 5.00 will be added. I'm not sure what others think?
Hi Sally, Thank you for testing and your comments. I tested again with a item type BK "Books" with a charge of 5.01, checked out an item of this type to a patron, and I get the following in OPAC (Renew is a link in blue): Renew Fee for Books 5.01 (10 of 10 renewals remaining) Hmm, why does it work here and not in your system? - What do you have as item type? Regarding the text changes: I think it makes sense to say something about the item type, since the charge can be different for each item type. So maybe something like: NOTE: A charge of 5.00 for Books will be added.
Hi Marc, The language revision of: NOTE: A charge of 5.00 for Books will be added - sounds good. I've just tested again using the sandbox at: http://sandbox1.ptfs-europe.co.uk/ with the MARC21 database. I'm using a DVD with an item type of "DVD Film" and a collection code of "Film media" - but it returns 'fee for Books', rather than 'fee for DVD Film' as I would expect: Black snake moan [dvd] 02/07/2016 39999000016611 Renew Fee for Books 1.00 (5 of 5 renewals remaining) I'm not sure what's causing the discrepancy; when you test with an item other than a book, does it return the correct item type? Thanks for your work on this - it'd be great to get this into Koha.
Created attachment 53051 [details] [review] Bug 13796: OPAC: Display rental charge for renewing This patch displays the rental fee that will be applied for renewing (near "Renew" link on patron's summary page) To test: - Apply patch - Verify that you have item types with and without rental fee for testing - Issue items with an without rental fee to a patron - In OPAC, display patron's summary page - Verify in table 'Checked out', items with rental charge display an information as appropriate (near the link 'Renew')
(In reply to Sally Healey from comment #5) > Hi Marc, > > The language revision of: NOTE: A charge of 5.00 for Books will be added - > sounds good. > > I've just tested again using the sandbox at: > http://sandbox1.ptfs-europe.co.uk/ with the MARC21 database. > > I'm using a DVD with an item type of "DVD Film" and a collection code of > "Film media" - but it returns 'fee for Books', rather than 'fee for DVD > Film' as I would expect: > > Black snake moan [dvd] 02/07/2016 39999000016611 Renew Fee for Books 1.00 > (5 of 5 renewals remaining) > > I'm not sure what's causing the discrepancy; when you test with an item > other than a book, does it return the correct item type? > > Thanks for your work on this - it'd be great to get this into Koha. Hi Sally, thanks for testing. I did some changes. Can you please test again? On my site, Item types like Books, Hardware, Music appear as expected: Renew Fee for Books 5.01 (8 of 10 renewals remaining) Renew Fee for Hardware 1.25 (9 of 10 renewals remaining) Renew Fee for Music 5.00 (10 of 10 renewals remaining)
Created attachment 53052 [details] [review] Bug 13796: OPAC: Display rental charge for renewing This patch displays the rental fee that will be applied for renewing (near "Renew" link on patron's summary page) To test: - Apply patch - Verify that you have item types with and without rental fee for testing - Issue items with an without rental fee to a patron - In OPAC, display patron's summary page - Verify in table 'Checked out', items with rental charge display an information as appropriate (near the link 'Renew')
Patch tested with a sandbox, by Sally Healey <sally.healey@cheshiresharedservices.gov.uk>
Created attachment 53476 [details] [review] Bug 13796: OPAC: Display rental charge for renewing This patch displays the rental fee that will be applied for renewing (near "Renew" link on patron's summary page) To test: - Apply patch - Verify that you have item types with and without rental fee for testing - Issue items with an without rental fee to a patron - In OPAC, display patron's summary page - Verify in table 'Checked out', items with rental charge display an information as appropriate (near the link 'Renew') Signed-off-by: Sally Healey <sally.healey@cheshiresharedservices.gov.uk>
I don't think we have found the best formatting for the fee sentence. It shows: Renew Fee for VHS 5.00 (2 of 3 renewals remaining) I think it's a bit confusing. Owen, any ideas?
Hm, also keep an eye on capitalisation please!
Thinking about wording. Prerequisites: Readability. As short as possible (we are in a table column). Translation friendly (no sentence splitting). Rules for capitalization (normally, item type name is capitalized). Word 'Renew' is a link (blue), rest is text (black). Without renewal fee (as is) --------------------------- Renew (10 of 10 renewals remaining) With renewal fee: ----------------- Variant I (as proposed by patch): Renew Fee for Books 5.00 (2 of 3 renewals remaining) Renew Fee for VHS 5.00 (2 of 3 renewals remaining)) Variant II: Renew. Fee for item type 'Books': 5.55. (10 of 10 renewals remaining) Renew. Fee for item type 'VHS': 5.55. (10 of 10 renewals remaining) Variant III: Renew (10 of 10 renewals remaining) Fee for item type 'Books': 3.75 Renew (10 of 10 renewals remaining) Fee for item type 'VHS': 3.75 Variant IV: Renew (10 of 10 renewals remaining) Fee (item type 'Books'): 3.75 Renew (10 of 10 renewals remaining) Fee (item type 'VHS'): 3.75 Variant V: Renew (10 of 10 renewals remaining) A fee of 4.25 will be added for item type 'Books' Renew (10 of 10 renewals remaining) A fee of 4.25 will be added for item type 'VHS' Variant VI: Renew (10 of 10 renewals remaining) NOTE: A fee of 4.25 will be added for item type 'Books' Renew (10 of 10 renewals remaining) NOTE: A fee of 4.25 will be added for item type 'VHS' Other propositions?
I think Variant III is the best.
Variant III by native speaker ;) Marc, can you please adapt and resubmit? I have checked the patch itself - it works as described.
Created attachment 54126 [details] [review] Bug 13796: (followup) Change wording to variant III See comments #13 - 15
I hope it's OK to switch back to 'Signed off'
Created attachment 54188 [details] [review] Bug 13796: OPAC: Display rental charge for renewing This patch displays the rental fee that will be applied for renewing (near "Renew" link on patron's summary page) To test: - Apply patch - Verify that you have item types with and without rental fee for testing - Issue items with an without rental fee to a patron - In OPAC, display patron's summary page - Verify in table 'Checked out', items with rental charge display an information as appropriate (near the link 'Renew') Signed-off-by: Sally Healey <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 54189 [details] [review] Bug 13796: (followup) Change wording to variant III See comments #13 - 15 Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 62535 [details] [review] Bug 13796: OPAC: Display rental charge for renewing This patch displays the rental fee that will be applied for renewing (near "Renew" link on patron's summary page) To test: - Apply patch - Enable system preference 'OpacRenewalAllowed' - Verify that you have item types with and without rental fee for testing - Issue items with an without rental fee to a patron - In OPAC, display patron's summary page - Verify in table 'Checked out', items with rental charge display an information as appropriate (near the link 'Renew') Patch rewritten because of merge issues with previous patches. 2017-04-21 mv
Patch rewritten because of problems with applying, needs a new sign-off.
Still applies on current master
Created attachment 65397 [details] [review] [SIGNED-OFF] Bug 13796: OPAC: Display rental charge for renewing This patch displays the rental fee that will be applied for renewing (near "Renew" link on patron's summary page) To test: - Apply patch - Enable system preference 'OpacRenewalAllowed' - Verify that you have item types with and without rental fee for testing - Issue items with an without rental fee to a patron - In OPAC, display patron's summary page - Verify in table 'Checked out', items with rental charge display an information as appropriate (near the link 'Renew') Patch rewritten because of merge issues with previous patches. 2017-04-21 mv Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Minor issue, the renewals remaining have been moved into the conditional so they will only show if the patron can renew the item themselves. Can be solved easily with an ELSE on canrenew.
(In reply to Kyle M Hall from comment #25) > Minor issue, the renewals remaining have been moved into the conditional so > they will only show if the patron can renew the item themselves. Can be > solved easily with an ELSE on canrenew. Sorry, I have no time ATM. Can you provide a counter patch?
Created attachment 67272 [details] [review] Bug 13796: OPAC: Display rental charge for renewing This patch displays the rental fee that will be applied for renewing (near "Renew" link on patron's summary page) To test: - Apply patch - Enable system preference 'OpacRenewalAllowed' - Verify that you have item types with and without rental fee for testing - Issue items with an without rental fee to a patron - In OPAC, display patron's summary page - Verify in table 'Checked out', items with rental charge display an information as appropriate (near the link 'Renew') Patch rewritten because of merge issues with previous patches. 2017-04-21 mv Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 67273 [details] [review] Bug 13796: (follow-up) Move renewal remaining statement back This moved the renewals remaining statement back out of the condition so it's visible always - with and without a rental fine on the item type.
I've moved the statement back out of the condition as per Kyle's suggestion.
(In reply to Katrin Fischer from comment #29) > I've moved the statement back out of the condition as per Kyle's suggestion. Hi Katrin, thanks for fixing it. Marc
Created attachment 68742 [details] [review] Bug 13796: OPAC: Display rental charge for renewing This patch displays the rental fee that will be applied for renewing (near "Renew" link on patron's summary page) To test: - Apply patch - Enable system preference 'OpacRenewalAllowed' - Verify that you have item types with and without rental fee for testing - Issue items with an without rental fee to a patron - In OPAC, display patron's summary page - Verify in table 'Checked out', items with rental charge display an information as appropriate (near the link 'Renew') Patch rewritten because of merge issues with previous patches. 2017-04-21 mv Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 68743 [details] [review] Bug 13796: (follow-up) Move renewal remaining statement back This moved the renewals remaining statement back out of the condition so it's visible always - with and without a rental fine on the item type. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Pushed to master for 17.11, thanks to everybody involved!