We need to be able to add a fine for borrowers for each overdueletter we send them. This patch makes the necessary DB modifications to add the fines-columns and CRUD them.
Created attachment 36764 [details] [review] Bug 13816 - Set Overdue letter fine to the overduerules This patch makes the necessary DB modifications to add the fines-columns and CRUD them using the tools/overduerules.pl This is a good basis for defining a cost or a fine for sending the notification, as sending them usually costs some money. TEST PLAN: Modify the overduerules and fines-column. Save changes. Observe the changes persist on page reloads. Unit test cases are not broken and give no extra errors.
Hi Olli-Antti, Could you take a look at Bug 12769? The patch was developed in 2014 to address the issue of adding a fee to any kind of notice, including overdue notices, and from what I see, your needs could be covered by that patch. Since we are all submitting patches that do relatively the same thing, we will have to get behind one of them to have any chance of making it to the master branch. Tell us what you think in Bug 12769.
This patch looks clean, but is missing any logic for actually charging the fines. I think we need to agree on something soon, at the moment it seems bugs are just blocking each other. Could both make sense? A 'overdue fee' per branch-patron category-overdue level and a more general fee on the letter?