Bug 13816 - Set Overdue letter fine to the overduerules
Summary: Set Overdue letter fine to the overduerules
Status: Failed QA
Alias: None
Product: Koha
Classification: Unclassified
Component: Notices (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-03-10 12:53 UTC by Olli-Antti Kivilahti
Modified: 2023-10-28 15:17 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 13816 - Set Overdue letter fine to the overduerules (9.90 KB, patch)
2015-03-10 13:13 UTC, Olli-Antti Kivilahti
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Olli-Antti Kivilahti 2015-03-10 12:53:36 UTC
We need to be able to add a fine for borrowers for each overdueletter we send them.

This patch makes the necessary DB modifications to add the fines-columns and CRUD them.
Comment 1 Olli-Antti Kivilahti 2015-03-10 13:13:00 UTC
Created attachment 36764 [details] [review]
Bug 13816 - Set Overdue letter fine to the overduerules

This patch makes the necessary DB modifications to add the fines-columns
and CRUD them using the tools/overduerules.pl

This is a good basis for defining a cost or a fine for sending the
notification, as sending them usually costs some money.

TEST PLAN:
Modify the overduerules and fines-column.
Save changes.
Observe the changes persist on page reloads.

Unit test cases are not broken and give no extra errors.
Comment 2 Charles Farmer 2015-10-16 13:22:34 UTC
Hi Olli-Antti,

Could you take a look at Bug 12769? The patch was developed in 2014 to address the issue of adding a fee to any kind of notice, including overdue notices, and from what I see, your needs could be covered by that patch.

Since we are all submitting patches that do relatively the same thing, we will have to get behind one of them to have any chance of making it to the master branch. Tell us what you think in Bug 12769.
Comment 3 Katrin Fischer 2017-08-17 22:40:21 UTC
This patch looks clean, but is missing any logic for actually charging the fines.
I think we need to agree on something soon, at the moment it seems bugs are just blocking each other.

Could both make sense? A 'overdue fee' per branch-patron category-overdue level and a more general fee on the letter?