When working with the 'holds awaiting pickup' report, after cancelling a hold that has not been picked up, you are redirected to the first tab. It would be nice if the redirect led you to the second tab to save a click when working on cancelling the holds. To test: - Go to the holds awaiting pickup report from the circulation start page - you will need some holds that appear on the 'hold(s) over' tab - cancel a hold from this tab - verify you are redirected to the report page with the first tab 'Hold(s) waiting' selected
*** Bug 14028 has been marked as a duplicate of this bug. ***
Created attachment 38208 [details] [review] Bug 13838 - Redirect to 'expired holds' tab after cancelling a hold When canceling a hold from the holds over tab, you are redirected back to the holds waiting tab. Instead, we should the librarian should continue to see the list of holds past the waiting length. Test Plan: 1) Apply this patch 2) Cancel a hold from the "Holds over" tab on circ/waitingreserves.pl 3) Note you are redirected back to the holds over tab
The test plan works, but I am redirected to the Hold(s) over tab even if I deleted a waiting hold (first tab).
Created attachment 45531 [details] [review] Bug 13838 - Redirect to 'expired holds' tab after cancelling a hold When canceling a hold from the holds over tab, you are redirected back to the holds waiting tab. Instead, we should the librarian should continue to see the list of holds past the waiting length. Test Plan: 1) Apply this patch 2) Cancel a hold from the "Holds over" tab on circ/waitingreserves.pl 3) Note you are redirected back to the holds over tab
Created attachment 45556 [details] [review] Bug 13838 - Redirect to 'expired holds' tab after cancelling a hold When canceling a hold from the holds over tab, you are redirected back to the holds waiting tab. Instead, we should the librarian should continue to see the list of holds past the waiting length. Test Plan: 1) Apply this patch 2) Cancel a hold from the "Holds over" tab on circ/waitingreserves.pl 3) Note you are redirected back to the holds over tab Signed-off-by: Tom Misilo <misilot@fit.edu>
Jonathan, I tested your case as well, and it does not appear to do that with the latest patch.
Created attachment 45596 [details] [review] Bug 13838 - Redirect to 'expired holds' tab after cancelling a hold When canceling a hold from the holds over tab, you are redirected back to the holds waiting tab. Instead, we should the librarian should continue to see the list of holds past the waiting length. Test Plan: 1) Apply this patch 2) Cancel a hold from the "Holds over" tab on circ/waitingreserves.pl 3) Note you are redirected back to the holds over tab Signed-off-by: Tom Misilo <misilot@fit.edu> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed to master!
Patch pushed to 3.22.x, will be in 3.22.1
This patch has been pushed to 3.20.x, will be in 3.20.7.