Add selected patrons to: at the top of the patron search result table is hard to translate correctly, because the 'to:' appears as a separate string. <span> Add selected patrons <label for="add_to_patron_list">to:</label> Results in: Add selected patrons to:
Created attachment 36966 [details] [review] Bug 13856: Hard to translate strings on patron search results page 'Add selected patrons to:' at the top of the patron search result table is hard to translate correctly, because the 'to:' appears as a separate string from the rest of the sentence. To test: - Make sure patron lists are activated - Do a patron search with more than 1 result - Look for the text at the top of the search results table - Verify it looks the same before and after the patch Bonus: - run perl translate update <langcode> and verify the 2 strings are now 1 string with the patch applied
Created attachment 36993 [details] [review] Bug 13856: Hard to translate strings on patron search results page 'Add selected patrons to:' at the top of the patron search result table is hard to translate correctly, because the 'to:' appears as a separate string from the rest of the sentence. To test: - Make sure patron lists are activated - Do a patron search with more than 1 result - Look for the text at the top of the search results table - Verify it looks the same before and after the patch Bonus: - run perl translate update <langcode> and verify the 2 strings are now 1 string with the patch applied Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net>
Created attachment 36998 [details] [review] Bug 13856: Hard to translate strings on patron search results page 'Add selected patrons to:' at the top of the patron search result table is hard to translate correctly, because the 'to:' appears as a separate string from the rest of the sentence. To test: - Make sure patron lists are activated - Do a patron search with more than 1 result - Look for the text at the top of the search results table - Verify it looks the same before and after the patch Bonus: - run perl translate update <langcode> and verify the 2 strings are now 1 string with the patch applied Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Patch pushed to master. Nice catch Katrina!
Pushed to 3.18.x will be in 3.18.6