On the last step of saving a new guided report to the database, the button is labelled "Save Report", but should be "Save report".
Created attachment 36996 [details] [review] Bug 13869: Wrong capitalization of 'Save Report' in guided reports On the last step of saving a new guided report to the database, the button is labelled 'Save Report', but should be 'Save report'. To test: - Create a new guided report from the reports page - Check on the very last step, when saving the report to the database, the button is labelled 'Save Report' - With the patch applied, this reads 'Save report' instead http://bugs.koha-community.org/show_bug.cgi?id=13868
Please test carefully -- In Guided Reports the label on the button might be used as a parameter by the script for determining what action to take.
Good point Owen - I avoided changing other occurrences and only changed the value that is getting translated. So I hope the change is save. :)
Created attachment 37050 [details] [review] [Signed-off] Bug 13869: Wrong capitalization of 'Save Report' in guided reports On the last step of saving a new guided report to the database, the button is labelled 'Save Report', but should be 'Save report'. To test: - Create a new guided report from the reports page - Check on the very last step, when saving the report to the database, the button is labelled 'Save Report' - With the patch applied, this reads 'Save report' instead http://bugs.koha-community.org/show_bug.cgi?id=13868 Works as expected. Signed-off-by: Marc Véron <veron@veron.ch>
Created attachment 37308 [details] [review] [PASSED QA] Bug 13869: Wrong capitalization of 'Save Report' in guided reports On the last step of saving a new guided report to the database, the button is labelled 'Save Report', but should be 'Save report'. To test: - Create a new guided report from the reports page - Check on the very last step, when saving the report to the database, the button is labelled 'Save Report' - With the patch applied, this reads 'Save report' instead http://bugs.koha-community.org/show_bug.cgi?id=13868 Works as expected. Signed-off-by: Marc Veron <veron@veron.ch> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Safe change. Script uses the "phase" variable which remains "Save Report"
Patch pushed to master. Thanks Katrina!
Pushed to 3.18.x will be in 3.18.6