The new help for Koha 3.18.5 has a typo in line 9 for "columsn" word. The section name does not fit with the module i.e. title in staff client says "Columns settings" in help says "Column Settings" even title section doesn't follow coding guideline HTML4: Upper and lower cases in strings at wiki <http://wiki.koha-community.org/wiki/Coding_Guidelines#HTML4:_Upper_and_lower_cases_in_strings>
Created attachment 36997 [details] [review] Bug 13872 - Typographical error on columns_settings.tt Bug 13872 - Typographical error on columns_settings.tt Test plan: 1) Go to url 'koha-tmpl/intranet-tmpl/prog/en/modules/help/admin/columns_set 2) See also changes for Column settings to Columns settings at lines 3 and 1 3) Apply the patch 4) Repeat step 1 and chek if the typo is fixed or go to Administration > Add Sponsored-by: Universidad de El Salvador Signed-off-by: Hector Eduardo Castro Avalos <hector.hecaxmmx@gmail.com>
Sorry, Rewording test plan Bug 13872 - Typographical error on columns_settings.tt Test plan: 1) Go to url 'koha-tmpl/intranet-tmpl/prog/en/modules/help/admin/columns_settings.tt' line 9 and check the typo "columsn" and change for columns. 2) See also changes for Column settings to Columns settings at lines 3 and 15 3) Apply the patch 4) Repeat step 1 and chek if the typo is fixed or go to Administration > Additional parameters > Configure columns and go to Help page. Sponsored-by: Universidad de El Salvador Signed-off-by: Hector Eduardo Castro Avalos <hector.hecaxmmx@gmail.com>
Thanks for finding the typo, but be aware that the help files haven't followed the capitalization rules in the past. Nicole
(In reply to Nicole C. Engard from comment #3) > Thanks for finding the typo, but be aware that the help files haven't > followed the capitalization rules in the past. > > Nicole Hi Nicole I will change the patch about the capitalization and let it as the original one, what would you recommend me to do? By the way there are another typo in file: intranet-tmpl/prog/en/modules/help/admin/aqbudgets.tt:15 It reads: In the form that appears you wan to enter the basics about your fund. I will file a new bug for the typo and link it with this as See also. Regards
Created attachment 37026 [details] [review] [Signed off] Bug 13872 - Typographical error on columns_settings.tt Test plan: 1) Go to url 'koha-tmpl/intranet-tmpl/prog/en/modules/help/admin/columns_settings.tt' line 9 and check the typo "columsn" and change for columns. 2) See also changes for Column settings to Columns settings at lines 3 and 15 3) Apply the patch 4) Repeat step 1 and chek if the typo is fixed or go to Administration > Additional parameters > Configure columns and go to Help page. Sponsored-by: Universidad de El Salvador Signed-off-by: Hector Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> Typo is fixed Signed-off-by: Marc Véron <veron@veron.ch>
This is a-ok the way it was, just wanted you to know that you don't have to go through every help file and fix it because with the next release they'll probably get put back since I just copy from the manual and paste to the help files. Nicole
Created attachment 37083 [details] [review] [PASSED QA] Bug 13872 - Typographical error on columns_settings.tt Test plan: 1) Go to url 'koha-tmpl/intranet-tmpl/prog/en/modules/help/admin/columns_settings.tt' line 9 and check the typo "columsn" and change for columns. 2) See also changes for Column settings to Columns settings at lines 3 and 15 3) Apply the patch 4) Repeat step 1 and chek if the typo is fixed or go to Administration > Additional parameters > Configure columns and go to Help page. Sponsored-by: Universidad de El Salvador Signed-off-by: Hector Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> Typo is fixed Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Patch pushed to master. Gracias Hector!
Pushed to 3.18.x will be in 3.18.6