reserve/request.pl currently uses C4::Members::Search. To get rid of SQLHelper, we should not use this subroutine anymore.
Created attachment 37124 [details] [review] Bug 13894: Make reserve.pl not using C4::Members::Search Important note: This will modify the UI. The patron list will now be displayed in a table (instead of a select). Test plan: 1/ Place a hold on a record 2/ Search for a patron 3/ Select a patron and submit 4/ The hold workflow should continue as previously No beviavior changes should be observed.
Note that this method will be applied to the circulation patron selection if this reach an agreement.
Created attachment 37171 [details] [review] [Signed-off] Bug 13894: Make reserve.pl not using C4::Members::Search Important note: This will modify the UI. The patron list will now be displayed in a table (instead of a select). Test plan: 1/ Place a hold on a record 2/ Search for a patron 3/ Select a patron and submit 4/ The hold workflow should continue as previously No behavior changes should be observed. Works as expected. Signed-off-by: Marc Véron <veron@veron.ch>
Created attachment 37330 [details] [review] [PASSED QA] Bug 13894: Make reserve.pl not using C4::Members::Search Important note: This will modify the UI. The patron list will now be displayed in a table (instead of a select). Test plan: 1/ Place a hold on a record 2/ Search for a patron 3/ Select a patron and submit 4/ The hold workflow should continue as previously No behavior changes should be observed. Works as expected. Signed-off-by: Marc Veron <veron@veron.ch> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 37361 [details] [review] Bug 13894: Fix if the search returns only 1 result In the case where only 1 result is returned by the search, the borrowernumber should be passed correctly.
Patch pushed to master. Thanks Jonathan!
(In reply to Tomás Cohen Arazi from comment #6) > Patch pushed to master. > > Thanks Jonathan! There is something wrong with the last past, the patrons search (using the checkout tab) is broken. Working on it and will submit a patch asap.
Comment on attachment 37361 [details] [review] Bug 13894: Fix if the search returns only 1 result Review of attachment 37361 [details] [review]: ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt @@ +487,4 @@ > [% END %] > > > +[% IF ( borrowers ) %] This change was for bug 13926.
Patch on bug 13936, sorry for that.