Bug 13915 - Inventory tool no longer hides items with date last seen greater than the inventory date
Summary: Inventory tool no longer hides items with date last seen greater than the inv...
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Tools (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Kyle M Hall
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-03-26 12:40 UTC by Kyle M Hall
Modified: 2018-06-04 20:10 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 13915 - Inventory tool no longer hides items with date last seen greater than the inventory date (1.87 KB, patch)
2015-03-26 12:42 UTC, Kyle M Hall
Details | Diff | Splinter Review
[Signed-off] Bug 13915 - Inventory tool no longer hides items with date last seen greater than the inventory date (2.05 KB, patch)
2015-03-27 16:35 UTC, Marc Véron
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Kyle M Hall 2015-03-26 12:40:29 UTC
In previous versions of Koha, selecting an inventory date would filter out items that had been seen since the "Inventory date". Bug 12631 changed the inventory tool so that this behavior only occurs when a barcodes list file is uploaded for comparison.
Comment 1 Kyle M Hall 2015-03-26 12:42:32 UTC Comment hidden (obsolete)
Comment 2 Kyle M Hall 2015-03-26 12:48:42 UTC
Correction, bug 12631 is not the culprit in causing this regression. It was just the last patch to change this line of code.
Comment 3 Marc Véron 2015-03-27 16:35:59 UTC
Created attachment 37333 [details] [review]
[Signed-off] Bug 13915 - Inventory tool no longer hides items with date last seen greater than the inventory date

In previous versions of Koha, selecting an inventory date would filter
out items that had been seen since the "Inventory date". Bug 12631
changed the inventory tool so that this behavior only occurs when a
barcodes list file is uploaded for comparison.

Test Plan:
1) Apply this patch
2) Run the inventory tool with no set parameters
3) Mark the first item as seen
4) Rerun the tool with only a date last seen parameter
   of yesterday
5) Note the item you marked as seen is no longer on the list

Followed test plan. Works as expected.
Signed-off-by: Marc Véron <veron@veron.ch>
Comment 4 Katrin Fischer 2015-04-05 22:16:08 UTC
The search option is named 'inventory date' - If I understood correctly, this could be more clear as 'inventory date before'?
Comment 5 Katrin Fischer 2015-04-05 22:23:23 UTC
Bit confused as the following lines were introduced by bug 12631 and are undone here:

Patch from 12631:
+    my $paramdatelastseen = ($compareinv2barcd) ? $datelastseen : ''; 
+    ($inventorylist, $totalrecords) = GetItemsForInventory($minlocation, $maxlocation, $location, $itemtype, $ignoreissued, $paramdatelastseen, $branchcode, $branch, 0, undef, $staton);

Patch attached to this bug:
-    my $paramdatelastseen = ($compareinv2barcd) ? $datelastseen : '';
-    ($inventorylist, $totalrecords) = GetItemsForInventory($minlocation, $maxlocation, $location, $itemtype, $ignoreissued, $paramdatelastseen, $branchcode, $branch, 0, undef, $staton);
+    ($inventorylist, $totalrecords) = GetItemsForInventory($minlocation, $maxlocation, $location, $itemtype, $ignoreissued, $datelastseen, $branchcode, $branch, 0, undef, $staton);

Are we sure there is no regression on bug 12631 by this change? I had problems testing 12631 when I tried, so not sure. Can you please take a look and explain?

The test plan works for me - I'd just like to be careful.
Comment 6 Marcel de Rooy 2017-11-06 12:25:02 UTC
Seems this could be closed in favor of bugs 12913/14399.