Tested in 3.18.5.1: - item is checked out to patron A - patron B places an item level hold on the item - patron A renews all - item is renewed :( Can someone confirm? I think there is no configuration option that should allow this, but maybe I am missing something.
This also affects the staff interface: when checking out the item again to another user, I get a warning that there is a hold. I override that and check it out anyway - and I am offfered the option to renew it. Soemthing is seriously going wrong here.
In my setup it's AllowRenewalIfOtherItemsAvailable that makes the difference. Switching that makes the difference between seeing the checkbox in the OPAC and the 'on hold' message in the staff client. I understood it should only allow renewal if items are available to fill the hold - so I think this is a bug, as the other existing item can't fill the hold here.
Created attachment 37376 [details] [review] Bug 13919 - Unit Test
Created attachment 37377 [details] [review] Bug 13919 - Renewal possible with item level hold on item Test Plan: 1) Apply this patch 2) Enable AllowRenewalIfOtherItemsAvailable 3) Check out an item from a record with multiple holdable items 4) Place an item level hold on the checked out item 5) Verify the item can not be renewed from the opac
The "renew all" button appears (same as intranet), should not we remove it?
I had 2 items, 1 with an hold (not renewable). I clicked on "renew all" and got "Please note: Your loan renewal failed because of the following reason(s): This item is on hold for another patron." 1 has been renewed (Renewed!) not the other. Could we get another tester on this one please?
Hm, but only the item without the hold was renewed? Or was the item with the hold renewed? I think the confusing message stems is what I noticed on bug 13913 - it just lists without telling you how many or which item.
Created attachment 37721 [details] [review] Bug 13919 - Renewal possible with item level hold on item Test Plan: 1) Apply this patch 2) Enable AllowRenewalIfOtherItemsAvailable 3) Check out an item from a record with multiple holdable items 4) Place an item level hold on the checked out item 5) Verify the item can not be renewed from the opac Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr>
Created attachment 37722 [details] [review] Bug 13919 - Renewal possible with item level hold on item Test Plan: 1) Apply this patch 2) Enable AllowRenewalIfOtherItemsAvailable 3) Check out an item from a record with multiple holdable items 4) Place an item level hold on the checked out item 5) Verify the item can not be renewed from the opac Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr>
(In reply to Katrin Fischer from comment #7) > Hm, but only the item without the hold was renewed? Yes
Created attachment 37729 [details] [review] Bug 13919: Make the tests pass fixing the number of tests
Created attachment 38307 [details] [review] [Signed-off] Bug 13919 - Unit Test Tested both unit test patches together. Without main patch applied: do not pass as expected / with main patch pass OK as expected. Signed-off-by: Marc Véron <veron@veron.ch>
Created attachment 38308 [details] [review] [Signed-off] Bug 13919: Make the tests pass fixing the number of tests Signed-off-by: Marc Véron <veron@veron.ch>
Created attachment 38315 [details] [review] [Signed-off] Bug 13919 - Renewal possible with item level hold on item Test Plan: 1) Apply this patch 2) Enable AllowRenewalIfOtherItemsAvailable 3) Check out an item from a record with multiple holdable items 4) Place an item level hold on the checked out item 5) Verify the item can not be renewed from the opac Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr> Followed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch>
Created attachment 38377 [details] [review] [PASSED QA] Bug 13919 - Unit Test Tested both unit test patches together. Without main patch applied: do not pass as expected / with main patch pass OK as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 38378 [details] [review] [PASSED QA] Bug 13919: Make the tests pass fixing the number of tests Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 38379 [details] [review] [PASSED QA] Bug 13919 - Renewal possible with item level hold on item Test Plan: 1) Apply this patch 2) Enable AllowRenewalIfOtherItemsAvailable 3) Check out an item from a record with multiple holdable items 4) Place an item level hold on the checked out item 5) Verify the item can not be renewed from the opac Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr> Followed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Tested with various combinations of item level/record level holds and syspref settings - no problems found!
Patches pushed to master. Thanks Kyle!
*** Bug 14104 has been marked as a duplicate of this bug. ***
Pushed to 3.18.x will be in 3.18.7