Bug 13931 - Date of birth in patron search result and in autocomplete
Summary: Date of birth in patron search result and in autocomplete
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Patrons (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Jiri Kozlovsky
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks: 16211
  Show dependency treegraph
 
Reported: 2015-03-30 20:31 UTC by Josef Moravec
Modified: 2016-12-05 21:27 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 13931 - Added date of birth to member's search results table (intranet/cgi-bin/koha/members/member.pl) (5.96 KB, patch)
2015-04-14 09:36 UTC, Jiri Kozlovsky
Details | Diff | Splinter Review
Bug 13931 - Added patron's dateofbirth to autocomplete (4.34 KB, patch)
2015-04-14 10:22 UTC, Jiri Kozlovsky
Details | Diff | Splinter Review
Bug 13931 - Implemented patron's dateofbirth autocompletion into newest version of circ/ysearch.pl (2.13 KB, patch)
2015-04-14 10:36 UTC, Jiri Kozlovsky
Details | Diff | Splinter Review
Bug 13931 - Implemented date of birth in patron search result and in autocomplete (6.11 KB, patch)
2015-04-14 11:01 UTC, Jiri Kozlovsky
Details | Diff | Splinter Review
Bug 13931 - Fixed Licence & Copyright statements & refactored the code (24.92 KB, text/plain)
2015-04-17 12:53 UTC, Jiri Kozlovsky
Details
Columns wrong in result table (77.68 KB, image/png)
2015-04-19 06:03 UTC, Marc Véron
Details
Bug 13931 - Fix patron search result table heading, fix member.pl template params (1.59 KB, patch)
2015-11-10 12:17 UTC, Josef Moravec
Details | Diff | Splinter Review
Bug 13931 - Implemented date of birth in patron search result and in autocomplete (5.55 KB, patch)
2015-11-10 12:19 UTC, Josef Moravec
Details | Diff | Splinter Review
Bug 13931 - Fix patron search result table heading, fix member.pl template params (1.59 KB, patch)
2015-11-10 12:19 UTC, Josef Moravec
Details | Diff | Splinter Review
Bug 13931 - Date of birth in patron search result and in autocomplete (5.21 KB, patch)
2015-11-12 19:48 UTC, Josef Moravec
Details | Diff | Splinter Review
Bug 13931 - Date of birth in patron search result and in autocomplete (5.67 KB, patch)
2015-11-12 19:50 UTC, Josef Moravec
Details | Diff | Splinter Review
Bug 13931 - Date of birth in patron search result and in autocomplete (5.86 KB, patch)
2015-11-12 20:51 UTC, Frédéric Demians
Details | Diff | Splinter Review
Bug 13931 - Date of birth in patron search result and in autocomplete (5.92 KB, patch)
2015-11-20 16:54 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 13931 [QA Followup] - Fix whitespace error (2.18 KB, patch)
2015-11-20 16:56 UTC, Kyle M Hall
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Josef Moravec 2015-03-30 20:31:25 UTC
It would be nice to see the date of birth in patron search results and possibly in autocomplete in searchfield for patron which you are going to checking out to.
Comment 1 Jiri Kozlovsky 2015-04-14 09:36:54 UTC Comment hidden (obsolete)
Comment 2 Jiri Kozlovsky 2015-04-14 10:22:39 UTC Comment hidden (obsolete)
Comment 3 Jiri Kozlovsky 2015-04-14 10:36:06 UTC Comment hidden (obsolete)
Comment 4 Jiri Kozlovsky 2015-04-14 11:01:33 UTC Comment hidden (obsolete)
Comment 5 Jiri Kozlovsky 2015-04-14 11:11:34 UTC
Test plan:

1) Apply the patch
2) Type into search form patron's name & check his date of birth in autocompletion
3) Go to intranet/cgi-bin/koha/members/member.pl & submit a search with more than one result .. now should in the table appear patron's date of birth 
4) Try show/hide columns section if it works correctly for date of birth
5) Go to intranet/cgi-bin/koha/admin/columns_settings.pl -> go to patrons section & check there is dateofbirth & it's functionality
Comment 6 Jiri Kozlovsky 2015-04-17 12:53:04 UTC Comment hidden (obsolete)
Comment 7 Marc Véron 2015-04-19 06:03:39 UTC Comment hidden (obsolete)
Comment 8 Josef Moravec 2015-11-10 12:17:44 UTC Comment hidden (obsolete)
Comment 9 Josef Moravec 2015-11-10 12:19:32 UTC Comment hidden (obsolete)
Comment 10 Josef Moravec 2015-11-10 12:19:39 UTC Comment hidden (obsolete)
Comment 11 Josef Moravec 2015-11-10 12:22:03 UTC
I've rebased patchs on top of current master and made followup to fix the error in patron search results table heading.
Comment 12 Frédéric Demians 2015-11-12 07:17:34 UTC
Comment 7 issue is solved. Could you merge your 2 patches in one single patch? and include your test plan into the patch itself?

Remarque: Admin > Column settings > Patrons > memberresultst is respected in normal patron search result table: you can hide the new column dateofbirth if necessary. But this is not respected by the autocompletion search result. From my point of view, it's an issue. But it's worth noting.
Comment 13 Josef Moravec 2015-11-12 19:48:12 UTC Comment hidden (obsolete)
Comment 14 Josef Moravec 2015-11-12 19:50:03 UTC Comment hidden (obsolete)
Comment 15 Josef Moravec 2015-11-12 19:55:42 UTC
Thanks for testing Frédéric. 

I squashed the commits and again rebased on master.

I think the autocomplete is not configurable at all, so we could open new bug, if somebody need it.
Comment 16 Frédéric Demians 2015-11-12 20:31:38 UTC
> I think the autocomplete is not configurable at all, so we could open new
> bug, if somebody need it.

The other option would be to not add the date of birth to the autocompletion. I wrote earlier by mistake: "From my point of view, it's an issue." I think exactly the contrary, IMO it's NOT an issue. The date of birth doesn't take that much space, and add a valuable information on the autocompletion search result.
Comment 17 Frédéric Demians 2015-11-12 20:51:10 UTC Comment hidden (obsolete)
Comment 18 Kyle M Hall 2015-11-20 16:54:06 UTC
Created attachment 45062 [details] [review]
Bug 13931 - Date of birth in patron search result and in autocomplete

Test plan:
1) Apply the patch
2) Type into search form patron's name & check his date of birth in
   autocompletion
3) Go to intranet/cgi-bin/koha/members/member.pl & submit
   a search with more than one result .. now should in the table appear
   patron's date of birth
4) Try show/hide columns section if it works correctly for date of birth
5) Go to intranet/cgi-bin/koha/admin/columns_settings.pl -> go to
   patrons section & check there is dateofbirth & it's functionality

Signed-off-by: Frederic Demians <f.demians@tamil.fr>
  Works as described. Syspref dateformat respected. Column dateofbirth
  configurable, but mandatory on autocompletion search result.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 19 Kyle M Hall 2015-11-20 16:56:06 UTC
Created attachment 45065 [details] [review]
Bug 13931 [QA Followup] - Fix whitespace error
Comment 20 Kyle M Hall 2015-12-31 14:55:48 UTC
Pushed to master, thanks Josef!