While looking at bug 10906, I noticed that this bug existed as well, but it was not reported. Look at C4/Biblio.pm and find the GetBiblio function. It is obvious that it only returns undef or a HASH reference. However, serials/subscription-history.pl calls it expecting ($count, $biblio), which is wrong. 1) confirm the problem: $ git grep "=\s*GetBiblio\s*(" | grep subscription-history 2) apply the patch 3) confirm the fix: $ git grep "=\s*GetBiblio\s*(" | grep subscription-history -- The return value should be just a single parameter as expected. 4) run koha-qa test tools.
Created attachment 37443 [details] [review] Bug 13947: Correct call to GetBiblio to receive correct return value When you attempt to edit the manual history for a subscription, the title is blank. This is a result of an incorrect use of the GetBiblio function. TEST PLAN --------- 1) Log in to staff client 2) Serials 3) Search for an existing serial with manual history checked. -- creating one as needed is left as an exercise to the reader. 4) Click on the title of the serial for the details page. 5) Go to the Planning tab and click 'Edit History' -- Heading will be 'Subscription history for' without a title. 6) Apply patch 7) Refresh page. -- Heading will include the title correctly. 8) run koha qa test tools
Created attachment 37447 [details] [review] Bug 13947: Correct call to GetBiblio to receive correct return value When you attempt to edit the manual history for a subscription, the title is blank. This is a result of an incorrect use of the GetBiblio function. TEST PLAN --------- 1) Log in to staff client 2) Serials 3) Search for an existing serial with manual history checked. -- creating one as needed is left as an exercise to the reader. 4) Click on the title of the serial for the details page. 5) Go to the Planning tab and click 'Edit History' -- Heading will be 'Subscription history for' without a title. 6) Apply patch 7) Refresh page. -- Heading will include the title correctly. 8) run koha qa test tools Signed-off-by: Jacek Ablewicz <abl@biblos.pk.edu.pl>
Created attachment 37461 [details] [review] [PASSED QA] Bug 13947: Correct call to GetBiblio to receive correct return value When you attempt to edit the manual history for a subscription, the title is blank. This is a result of an incorrect use of the GetBiblio function. TEST PLAN --------- 1) Log in to staff client 2) Serials 3) Search for an existing serial with manual history checked. -- creating one as needed is left as an exercise to the reader. 4) Click on the title of the serial for the details page. 5) Go to the Planning tab and click 'Edit History' -- Heading will be 'Subscription history for' without a title. 6) Apply patch 7) Refresh page. -- Heading will include the title correctly. 8) run koha qa test tools Signed-off-by: Jacek Ablewicz <abl@biblos.pk.edu.pl> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Patch pushed to master. Thanks Mark!
Pushed to 3.18.x will be in 3.18.6