When doing a search for a patron from the checkout tab, using the autocomplete feature, the result list shows a 'null' at the end of each result line.
Introduced by bug 13892.
Created attachment 37548 [details] [review] Bug 13957: If not value, display an empty string instead of "null" Using the autocomplete feature in the patron search, if one value is missing (i.e. country), it will be replaced with 'null'. The default value should be an empty string. Test plan: 0/ Enable the patron autocomplete feature 1/ Create a patron without value for country 2/ Go on the circ home page 3/ Search for this patron. The country should not have been replaced by "null".
Created attachment 37549 [details] [review] Bug 13957: If no value, display an empty string instead of "null" Using the autocomplete feature in the patron search, if one value is missing (i.e. country), it will be replaced with 'null'. The default value should be an empty string. Test plan: 0/ Enable the patron autocomplete feature 1/ Create a patron without value for country 2/ Go on the circ home page 3/ Search for this patron. The country should not have been replaced by "null".
Created attachment 37566 [details] [review] Bug 13957: If no value, display an empty string instead of "null" Using the autocomplete feature in the patron search, if one value is missing (i.e. country), it will be replaced with 'null'. The default value should be an empty string. Test plan: 0/ Enable the patron autocomplete feature 1/ Create a patron without value for country, address, zipcode, city 2/ Go on the circ home page 3/ Search for this patron. The country should not have been replaced by "null". Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr> Current status: Needs Signoff
Created attachment 37567 [details] [review] Bug 13957: If no value, display an empty string instead of "null" Using the autocomplete feature in the patron search, if one value is missing (i.e. country), it will be replaced with 'null'. The default value should be an empty string. Test plan: 0/ Enable the patron autocomplete feature 1/ Create a patron without value for country, address, zipcode, city 2/ Go on the circ home page 3/ Search for this patron. The country should not have been replaced by "null". Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr>
Created attachment 37666 [details] [review] [PASSED QA] Bug 13957: If no value, display an empty string instead of "null" Using the autocomplete feature in the patron search, if one value is missing (i.e. country), it will be replaced with 'null'. The default value should be an empty string. Test plan: 0/ Enable the patron autocomplete feature 1/ Create a patron without value for country, address, zipcode, city 2/ Go on the circ home page 3/ Search for this patron. The country should not have been replaced by "null". Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Patch pushed to master. Thanks Jonathan!
Doesn't apply to 3.18.x please rebase if needed
(In reply to Chris Cormack from comment #8) > Doesn't apply to 3.18.x please rebase if needed Not needed, its introduced by bug 13892, which is not in 3.18.x