When using AcquisitionDetails a new tab is shown on the staff client detail page that shows order information from the acquisition module. Feedback at our user meeting was, that it would be nice to see the vendor for the orders there as well.
Created attachment 40050 [details] [review] Bug 13962: Add vendor to acq details tab in staff Implementing some feedback from our user meeting: The acquisition details tab on the detail page in staff should also show the vendor of the order. To test: - Make sure AcquisitionDetails is active. - Create an order or look up an order in the acqusition module. - Go to the ordered record and check the 'Acquisition details' tab - Verify the vendor shows up there as first column now - Check that sorting and display of the other columns are still working correctly Note: Also fixes a </th> that should be a </td>
Created attachment 40056 [details] [review] Bug 13962: Add vendor to acq details tab in staff Implementing some feedback from our user meeting: The acquisition details tab on the detail page in staff should also show the vendor of the order. To test: - Make sure AcquisitionDetails is active. - Create an order or look up an order in the acqusition module. - Go to the ordered record and check the 'Acquisition details' tab - Verify the vendor shows up there as first column now - Check that sorting and display of the other columns are still working correctly Note: Also fixes a </th> that should be a </td> Signed-off-by: Aleisha <aleishaamohia@hotmail.com>
Created attachment 40192 [details] [review] Bug 13962: Add vendor to acq details tab in staff Implementing some feedback from our user meeting: The acquisition details tab on the detail page in staff should also show the vendor of the order. To test: - Make sure AcquisitionDetails is active. - Create an order or look up an order in the acqusition module. - Go to the ordered record and check the 'Acquisition details' tab - Verify the vendor shows up there as first column now - Check that sorting and display of the other columns are still working correctly Note: Also fixes a </th> that should be a </td> Signed-off-by: Aleisha <aleishaamohia@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org>
Created attachment 40193 [details] [review] Bug 13962: Add link to the vendor detail page This patch 1/ uses the class of the th to filter the columns and 2/ adds a link on the vendor name to the vendor detail page. Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org>
Katrin, could you quickly confirm that you agree with my follow-up?
(In reply to Jonathan Druart from comment #5) > Katrin, could you quickly confirm that you agree with my follow-up? I was not expected a quick answer, but just to have a quick look :)
Patches pushed to master. Thanks Katrina!