Bug 13966 - Backport HEA to Koha 3.16 and/or 3.14
Summary: Backport HEA to Koha 3.16 and/or 3.14
Status: CLOSED WONTFIX
Alias: None
Product: Koha
Classification: Unclassified
Component: Database (show other bugs)
Version: 3.16
Hardware: All All
: P5 - low trivial (vote)
Assignee: Mason James
QA Contact: Testopia
URL:
Keywords:
Depends on: 11926
Blocks:
  Show dependency treegraph
 
Reported: 2015-04-08 07:11 UTC by Mason James
Modified: 2016-12-05 21:23 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 13966 - Backport HEA to Koha 3.16 and/or 3.14 (1.26 KB, patch)
2015-04-08 07:23 UTC, Mason James
Details | Diff | Splinter Review
Bug 13966 - Backport HEA to Koha 3.16 and/or 3.14 (1.35 KB, patch)
2015-04-17 08:03 UTC, Jonathan Druart
Details | Diff | Splinter Review
[PASSED QA] Bug 13966 - Backport HEA to Koha 3.16 and/or 3.14 (1.42 KB, patch)
2015-06-06 18:30 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Mason James 2015-04-08 07:11:44 UTC
This bug is to track the backport of the HEA feature to Koha 3.16 and/or 3.14
Comment 1 Mason James 2015-04-08 07:23:34 UTC Comment hidden (obsolete)
Comment 2 Mason James 2015-04-08 07:39:34 UTC
Once this patch is appears in a future Koha release, the HEA patchset can be added to older Kohas.

Note: this patch is not essential for HEA to be backported, as the 'duplicated rows' SQL warnings without this patch are harmless and not fatal - but it would be nice to avoid those warnings, if possible
Comment 3 Jonathan Druart 2015-04-08 08:16:49 UTC
What's the discussion here?
The patch does not apply on 3.14.x nor 3.16.x.
Comment 4 Mason James 2015-04-09 05:15:37 UTC
(In reply to Jonathan Druart from comment #3)
> What's the discussion here?
> The patch does not apply on 3.14.x nor 3.16.x.


the patch is only to be applied for the master/3.18.x branches

it's just to stop any 'duplicate rows' SQL upgrade warnings, when a 3.16/3.14 Koha upgrades to 3.18.x or higher

make sense?
Comment 5 Jonathan Druart 2015-04-09 07:51:45 UTC
(In reply to Mason James from comment #4)
> (In reply to Jonathan Druart from comment #3)
> > What's the discussion here?
> > The patch does not apply on 3.14.x nor 3.16.x.
> 
> 
> the patch is only to be applied for the master/3.18.x branches
> 
> it's just to stop any 'duplicate rows' SQL upgrade warnings, when a
> 3.16/3.14 Koha upgrades to 3.18.x or higher
> 
> make sense?

Ha yes, sorry. It defenitely makes sense!
So needs signoff :)
Comment 6 Mark Tompsett 2015-04-16 17:05:54 UTC
Test plan?
Comment 7 Jonathan Druart 2015-04-17 07:59:35 UTC
(In reply to M. Tompsett from comment #6)
> Test plan?

Test plan:
1/ Look at the patch
2/ You will know what you should test
3/ I you don't, test another patch
Comment 8 Jonathan Druart 2015-04-17 08:03:56 UTC Comment hidden (obsolete)
Comment 9 Katrin Fischer 2015-06-06 18:29:40 UTC
I think that now we need the patch in master, 3.20 and 3.18?
Comment 10 Katrin Fischer 2015-06-06 18:30:59 UTC
Created attachment 39954 [details] [review]
[PASSED QA] Bug 13966 - Backport HEA to Koha 3.16 and/or 3.14

This trivial patch stops any potential SQL errors/warnings for a HEA enabled 3.16 or 3.14 Koha, when upgrading to a newer Koha

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Add the missing prefs unless they exist and don't raise an error if already
exist.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 11 Mason James 2015-07-21 00:55:14 UTC
(In reply to Katrin Fischer from comment #9)
> I think that now we need the patch in master, 3.20 and 3.18?

yep, thats correct Katrin
Comment 12 Mason James 2015-12-14 03:33:48 UTC
(In reply to Katrin Fischer from comment #9)
> I think that now we need the patch in master, 3.20 and 3.18?

RMaints(In reply to Mason James from comment #11)
> (In reply to Katrin Fischer from comment #9)
> > I think that now we need the patch in master, 3.20 and 3.18?
> 
> yep, thats correct Katrin


Patch has passed QA, and is waiting to be pulled to master, 3.22, 3.20 and 3.18 branches
Comment 13 Mason James 2015-12-14 03:38:32 UTC
(In reply to Mason James from comment #12)
> (In reply to Katrin Fischer from comment #9)
> > I think that now we need the patch in master, 3.20 and 3.18?
> 
> RMaints(In reply to Mason James from comment #11)
> > (In reply to Katrin Fischer from comment #9)
> > > I think that now we need the patch in master, 3.20 and 3.18?
> > 
> > yep, thats correct Katrin
> 
> 
> Patch has passed QA, and is waiting to be pulled to master, 3.22, 3.20 and
> 3.18 branches

hmm, actually... this patch can probably be WONTFIX, as its for 2 very old Koha versions :)