13975 – Warning "Use of the encoding pragma is deprecated" in misc/export_borrowers.pl

Bug 13975 - Warning "Use of the encoding pragma is deprecated" in misc/export_borrowers.pl

Summary: Warning "Use of the encoding pragma is deprecated" in misc/export_borrowers.pl

Status:	CLOSED FIXED

Alias:	None

Product:	Koha
Classification:	Unclassified
Component:	Architecture, internals, and plumbing (show other bugs)
Version:	Main
Hardware:	All All

Importance:	P5 - low normal
Assignee:	Jonathan Druart
QA Contact:	Testopia

URL:
Keywords:

Depends on:
Blocks:

Reported:	2015-04-09 14:01 UTC by Jonathan Druart
Modified:	2015-12-03 22:02 UTC (History)
CC List:	4 users (show)

See Also:
Change sponsored?:	---
Patch complexity:	---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Bug 13975: Remove compilation warning about encoding pragma deprecation (1.35 KB, patch) 2015-04-09 14:12 UTC, Jonathan Druart	Details \| Diff \| Splinter Review
Bug 13975: Remove compilation warning about encoding pragma (1.50 KB, patch) 2015-04-11 10:19 UTC, Frédéric Demians	Details \| Diff \| Splinter Review
Bug 13975: Remove compilation warning about encoding pragma (1.57 KB, patch) 2015-04-17 11:12 UTC, Kyle M Hall (khall)	Details \| Diff \| Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Jonathan Druart 2015-04-09 14:01:34 UTC

% perl -wc misc/export_borrowers.pl
Use of the encoding pragma is deprecated at misc/export_borrowers.pl line 29.
misc/export_borrowers.pl syntax OK

Comment 1 Jonathan Druart 2015-04-09 14:12:22 UTC Comment hidden (obsolete)

Created attachment 37620 [details] [review]
Bug 13975: Remove compilation warning about encoding pragma deprecation

Test plan:
0/ Does not apply the patch
1/ Launch the export_borrowers.pl script to export data with unicode characters
 % perl misc/export_borrowers.pl -w "borrowernumber=42" --field borrowernumber --field surname --field firstname
  Use of the encoding pragma is deprecated at misc/export_borrowers.pl
  7874,JOUBU,صةصةصة
2/ Apply this patch
3/ Repeat 1
 % perl misc/export_borrowers.pl -w "borrowernumber=42" --field borrowernumber --field surname --field firstname
  7874,JOUBU,صةصةصة

Note that the deprecated message is gone and the encoding is correct.

Comment 2 Frédéric Demians 2015-04-11 10:19:27 UTC Comment hidden (obsolete)

Created attachment 37676 [details] [review]
Bug 13975: Remove compilation warning about encoding pragma

Signed-off-by: Frederic Demians <f.demians@tamil.fr>

  I confirm the warning (on Perl version above 5.14). And that the patch fix
  the warning.

Comment 3 Kyle M Hall (khall) 2015-04-17 11:12:14 UTC

Created attachment 38034 [details] [review]
Bug 13975: Remove compilation warning about encoding pragma

Comment 4 Tomás Cohen Arazi (tcohen) 2015-04-20 13:26:20 UTC

Patch pushed to master.

Thanks Jonathan!

Comment 5 Chris Cormack 2015-04-21 23:21:49 UTC

Pushed to 3.18.x will be in 3.18.6