The print list button only prints the page you are viewing, and not the entire list.
Created attachment 37761 [details] [review] Bug 13986 - Printing a list only prints the results of the page you are viewing The print list button only prints the page you are viewing, and not the entire list. Test Plan: 1) Apply this patch 2) Create a list with enough items that it will paginate 3) Browse to that list, click the 'print list' button 4) Note the entire list prints, not just the visible items
Created attachment 37773 [details] [review] [Signed-off] Bug 13986 - Printing a list only prints the results of the page you are viewing The print list button only prints the page you are viewing, and not the entire list. Test Plan: 1) Apply this patch 2) Create a list with enough items that it will paginate 3) Browse to that list, click the 'print list' button 4) Note the entire list prints, not just the visible items Tested in staff client, works as expected. It would be great to have the same for OPAC as well (OPAC still prints first page only). Signed-off-by: Marc Véron <veron@veron.ch>
Created attachment 38192 [details] [review] Bug 13419: Add server-side processing for lists This patch adds DataTables using a server-side processing to display lists (virtual shelves). Test plan: 1/ Go on virtualshelves/shelves.p 2/ Play with the table functions (sort, filter, pagination, etc.) 3/ Go with the Public lists tab and verify the table is correctly filtered. Tested together with patch #2, works as expected. Signed-off-by: Marc Veron <veron@veron.ch> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 38291 [details] [review] Bug 13986 - Implement fix for OPAC
Created attachment 38305 [details] [review] [Signde-off] Bug 13986 - Implement fix for OPAC Tested wit OPAC, full list is printed. Signed-off-by: Marc Véron <veron@veron.ch>
Sorry, patch does not apply and I am not sure how to fix the conflict - better leaving it to you.
Created attachment 38496 [details] [review] Bug 13986 - Printing a list only prints the results of the page you are viewing The print list button only prints the page you are viewing, and not the entire list. Test Plan: 1) Apply this patch 2) Create a list with enough items that it will paginate 3) Browse to that list, click the 'print list' button 4) Note the entire list prints, not just the visible items Tested in staff client, works as expected. It would be great to have the same for OPAC as well (OPAC still prints first page only). Signed-off-by: Marc Veron <veron@veron.ch>
Created attachment 38497 [details] [review] Bug 13986 - Implement fix for OPAC Tested wit OPAC, full list is printed. Signed-off-by: Marc Veron <veron@veron.ch>
I have started testing this - is there a way we could have the 'print preview' match what is actually going to be printed?
(In reply to Katrin Fischer from comment #9) > I have started testing this - is there a way we could have the 'print > preview' match what is actually going to be printed? I think there is now way to trigger the print preview from JavaScript, because the print preview is part of the browser. One workaround could be to create a separate page for printing, but that would be a different approach (and not a real print preview).
Kyle, Please provide tests for the changes in C4::VirtualShelves. I don't know if you feel comfortable with this code, but personally I am not at all. So maybe the better is to start and move the code into Koha::VirtualShelves.
(In reply to Jonathan Druart from comment #11) > So maybe the better is to start and move the code into Koha::VirtualShelves. Since your changes consist in adding a check, it's certainly a bit hard to start here...
C4::VirtualShelves has no unit tests. Further complicating the issue is that the code relies on CGI objects. I think the two small changes I made to C4::VirtualShelves::Page are pretty obvious and won't cause regressions. I can't imagine that this one small feature would justify rewriting VirtualShelves, but I do agree it could use a rewrite.
Created attachment 38725 [details] [review] Bug 13986 - Printing a list only prints the results of the page you are viewing The print list button only prints the page you are viewing, and not the entire list. Test Plan: 1) Apply this patch 2) Create a list with enough items that it will paginate 3) Browse to that list, click the 'print list' button 4) Note the entire list prints, not just the visible items Tested in staff client, works as expected. It would be great to have the same for OPAC as well (OPAC still prints first page only). Signed-off-by: Marc Veron <veron@veron.ch>
Created attachment 38726 [details] [review] Bug 13986 - Implement fix for OPAC Tested wit OPAC, full list is printed. Signed-off-by: Marc Veron <veron@veron.ch>
Created attachment 38780 [details] [review] [PASSED QA] Bug 13986 - Printing a list only prints the results of the page you are viewing The print list button only prints the page you are viewing, and not the entire list. Test Plan: 1) Apply this patch 2) Create a list with enough items that it will paginate 3) Browse to that list, click the 'print list' button 4) Note the entire list prints, not just the visible items Tested in staff client, works as expected. It would be great to have the same for OPAC as well (OPAC still prints first page only). Signed-off-by: Marc Veron <veron@veron.ch> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 38781 [details] [review] [PASSED QA] Bug 13986 - Implement fix for OPAC Tested wit OPAC, full list is printed. Signed-off-by: Marc Veron <veron@veron.ch> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
I am a little worried that this feature is hidden by the fact the print preview doesn't match the actual print out - but this is a good enhancement, no reason to hold it back :)
Patches pushed to master. Thanks Kyle!
Doesn't apply cleanly on 3.18.x please rebase if it is needed
Created attachment 39916 [details] [review] [v3.18.x] Bug 13986 - Printing a list only prints the results of the page you are viewing The print list button only prints the page you are viewing, and not the entire list. Test Plan: 1) Apply this patch 2) Create a list with enough items that it will paginate 3) Browse to that list, click the 'print list' button 4) Note the entire list prints, not just the visible items Tested in staff client, works as expected. It would be great to have the same for OPAC as well (OPAC still prints first page only). Signed-off-by: Marc Veron <veron@veron.ch> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Bug 13986 - Implement fix for OPAC Tested wit OPAC, full list is printed. Signed-off-by: Marc Veron <veron@veron.ch> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Does the rebased patch apply to 3.18.x?
*** Bug 13761 has been marked as a duplicate of this bug. ***
*** Bug 15372 has been marked as a duplicate of this bug. ***