To reproduce: Go to Home > Tools > Logs Check intranet-error.log. You will find a line similar to: viewlog.pl: Use of uninitialized value $src in string eq at (...)/tools/viewlog.pl line 70., referer: http://(...)/cgi-bin/koha/tools/tools-home.pl Reason: Line 57 my $src = $input->param("src"); Param is not always defined.
Created attachment 37791 [details] [review] Bug 13991 - Uninitialized value $src in /tools/viewlog.pl To reproduce: Go to Home > Tools > Logs Check intranet-error.log. You will find a line similar to: viewlog.pl: Use of uninitialized value $src in string eq at (...)/tools/viewlog.pl line 70., referer: http://(...)/cgi-bin/koha/tools/tools-home.pl To test: Apply patch. Verify that no more warnings appear in intranet-error.log Verify that the log viewer behaves as before.
Created attachment 37802 [details] [review] Bug 13991 - Uninitialized value $src in /tools/viewlog.pl To reproduce: Go to Home > Tools > Logs Check intranet-error.log. You will find a line similar to: viewlog.pl: Use of uninitialized value $src in string eq at (...)/tools/viewlog.pl line 70., referer: http://(...)/cgi-bin/koha/tools/tools-home.pl To test: Apply patch. Verify that no more warnings appear in intranet-error.log Verify that the log viewer behaves as before. Signed-off-by: Andreas Hedström Mace <andreas.hedstrom.mace@sub.su.se>
Created attachment 37922 [details] [review] [PASSED QA] Bug 13991 - Uninitialized value $src in /tools/viewlog.pl To reproduce: Go to Home > Tools > Logs Check intranet-error.log. You will find a line similar to: viewlog.pl: Use of uninitialized value $src in string eq at (...)/tools/viewlog.pl line 70., referer: http://(...)/cgi-bin/koha/tools/tools-home.pl To test: Apply patch. Verify that no more warnings appear in intranet-error.log Verify that the log viewer behaves as before. Signed-off-by: Andreas Hedström Mace <andreas.hedstrom.mace@sub.su.se> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 37980 [details] [review] Bug 13991: (QA followup) uninitialized value and [0] in /tools/viewlog.pl Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
Patch pushed to master. Thanks Marc!
Pushed to 3.18.x will be in 3.18.6