Bug 14041 - Use of uninitialized value in /usr/share/kohaclone/svc/checkouts
Summary: Use of uninitialized value in /usr/share/kohaclone/svc/checkouts
Status: CLOSED WORKSFORME
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-04-22 10:32 UTC by Marc Véron
Modified: 2016-12-05 21:23 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Marc Véron 2015-04-22 10:32:04 UTC
checkouts: Use of uninitialized value in string comparison (cmp) at /usr/share/kohaclone/svc/checkouts line 211
Comment 1 Aleisha Amohia 2015-06-09 22:17:19 UTC
Hi Marc, how can I recreate this bug?
Comment 2 Marc Véron 2015-06-10 06:07:38 UTC
Hi Aleisha,

I can no longer reproduce the warning. Line 211 in svc/checkouts is empty at current master.

However some lines below there are comparisions with C4::Context->preference('todaysIssuesDefaultSortOrder') and C4::Context->preference('previousIssuesDefaultSortOrder')

There are small differences in the way the sysprefs are defined in koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref after line 27. I do not think that they were the reason for the warning, but I document it for the records:

        -
            - Sort previous checkouts on the circulation page from
            - pref: previousIssuesDefaultSortOrder
              choices:
                  asc: earliest to latest
                  desc: latest to earliest
            - due date.
        -
            - "Sort today's checkouts on the circulation page from"
            - pref: todaysIssuesDefaultSortOrder
              type: choice
              choices:
                  asc: earliest to latest
                  desc: latest to earliest
            - due date.
Comment 3 Marc Véron 2016-04-25 12:38:20 UTC
Can no longer trigger the warning on current master.