Bug 14050 - Default framework for authorities should not be deletable
Summary: Default framework for authorities should not be deletable
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: MARC Authority data support (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial (vote)
Assignee: Marc Véron
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-04-22 20:03 UTC by Marc Véron
Modified: 2016-12-05 21:25 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 14050 - Default framework for authorities should not be deletable (1.87 KB, patch)
2016-04-25 13:05 UTC, Marc Véron
Details | Diff | Splinter Review
[SIGNED-OFF]Bug 14050: Default framework for authorities should not be deletable (1.97 KB, patch)
2016-04-25 14:29 UTC, Héctor Eduardo Castro Avalos
Details | Diff | Splinter Review
Bug 14050: Default framework for authorities should not be deletable (2.02 KB, patch)
2016-04-25 16:24 UTC, Jonathan Druart
Details | Diff | Splinter Review
[3.22.x] Bug 14050: Default framework for authorities should not be deletable (1.52 KB, patch)
2016-05-16 11:56 UTC, Julian Maurice
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Marc Véron 2015-04-22 20:03:02 UTC
If the default authority type is deleted (Home > Administration > Authority types), it can not be recreated, because there is no way to create an authority with an empty string as code.

The possibility to delete the default authority type should be removed.
Comment 1 Marc Véron 2016-04-25 13:05:13 UTC Comment hidden (obsolete)
Comment 2 Héctor Eduardo Castro Avalos 2016-04-25 14:29:20 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2016-04-25 16:24:10 UTC
Created attachment 50656 [details] [review]
Bug 14050: Default framework for authorities should not be deletable

To test:
- Apply patch
- In staff client, go to Home > Administration > Authority types
- Verify that the Actions for the Default type do not contain the delete
  action
- Verify that other types have a delete action

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Delete action was eliminated

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 4 Jonathan Druart 2016-04-25 16:25:47 UTC
I have talked with someone (Katrin maybe?) about this "bug", but I don't remember the conclusion.
Right now I don't see why we should allow this deletion, but I may miss something.
Comment 5 Kyle M Hall 2016-04-29 12:31:09 UTC
Pushed to master for the May 2016 release. Salamat po Marc!
Comment 6 Julian Maurice 2016-05-16 11:56:07 UTC
Created attachment 51525 [details] [review]
[3.22.x] Bug 14050: Default framework for authorities should not be deletable

Patch for 3.22.x
Comment 7 Julian Maurice 2016-05-16 11:56:22 UTC
Patch pushed to 3.22.x, will be in 3.22.7