If the default authority type is deleted (Home > Administration > Authority types), it can not be recreated, because there is no way to create an authority with an empty string as code. The possibility to delete the default authority type should be removed.
Created attachment 50633 [details] [review] Bug 14050 - Default framework for authorities should not be deletable To test: - Apply patch - In staff client, go to Home > Administration > Authority types - Verify that the Actions for the Default type do not contain the delete action - Verify that other types have a delete action
Created attachment 50638 [details] [review] [SIGNED-OFF]Bug 14050: Default framework for authorities should not be deletable To test: - Apply patch - In staff client, go to Home > Administration > Authority types - Verify that the Actions for the Default type do not contain the delete action - Verify that other types have a delete action Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Delete action was eliminated
Created attachment 50656 [details] [review] Bug 14050: Default framework for authorities should not be deletable To test: - Apply patch - In staff client, go to Home > Administration > Authority types - Verify that the Actions for the Default type do not contain the delete action - Verify that other types have a delete action Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Delete action was eliminated Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
I have talked with someone (Katrin maybe?) about this "bug", but I don't remember the conclusion. Right now I don't see why we should allow this deletion, but I may miss something.
Pushed to master for the May 2016 release. Salamat po Marc!
Created attachment 51525 [details] [review] [3.22.x] Bug 14050: Default framework for authorities should not be deletable Patch for 3.22.x
Patch pushed to 3.22.x, will be in 3.22.7