When deleting a holiday in the calendar, the description for 'Delete the exceptions within a range" reads --> "This will delete the exceptions inside a given range. Be careful about your scope range if it is oversized you could slow down Koha." Small punctuation error here - should have a hyphen ie ".. Be careful about your scope range - if it is oversized you could slow down Koha."
Created attachment 38470 [details] [review] Bug 14056 - Small punctuation error in description for deleting a holiday This patch just inserts a hyphen into the description so that it makes sense. Test plan: 1) Go to Tools --> Calendar 2) Create or find a holiday, click on it so the editing options come up 3) Click on the question mark link to show the description for the option "Delete the exceptions on a range" 4) Confirm that this now has a hyphen and reads ".. Be careful about your scope range - if it is oversized you could slow down Koha."
I'm not part of the grammar police, but it seems to me that hyphen is not the most natural and plain way of expressing this. Though, I definitely agree there needs a tweak somehow. Perhaps: Be careful about your scope range; if it is oversized, you could slow down Koha. instead?
Created attachment 38581 [details] [review] Bug 14056 - Small punctuation error in description for deleting a holiday This patch just inserts a semi-colon into the description so that it makes more grammatical sense. Test plan: 1) Go to Tools --> Calendar 2) Create or find a holiday, click on it so the editing options come up 3) Click on the question mark link to show the description for the option "Delete the exceptions on a range" 4) Confirm that this now has a semi-colon and reads ".. Be careful about your scope range - if it is oversized you could slow down Koha."
Created attachment 38583 [details] [review] Bug 14056 - Small punctuation error in description for deleting a holiday This patch just inserts a semi-colon into the description so that it makes more grammatical sense. Test plan: 1) Go to Tools --> Calendar 2) Create or find a holiday, click on it so the editing options come up 3) Click on the question mark link to show the description for the option "Delete the exceptions on a range" 4) Confirm that this now has a semi-colon and reads "... Be careful about your scope range; if it is oversized you could slow down Koha." Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Created attachment 38613 [details] [review] [PASSED QA] Bug 14056 - Small punctuation error in description for deleting a holiday This patch just inserts a semi-colon into the description so that it makes more grammatical sense. Test plan: 1) Go to Tools --> Calendar 2) Create or find a holiday, click on it so the editing options come up 3) Click on the question mark link to show the description for the option "Delete the exceptions on a range" 4) Confirm that this now has a semi-colon and reads "... Be careful about your scope range; if it is oversized you could slow down Koha." Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Patch pushed to master. Thanks Aleisha!
Pushed to 3.18.x will be in 3.18.7