if ($f and $sf) fails if: $f is NULL,'', or 0 and similarly with $sf. 952$0 = withdrawn status. This should be (defined $f and defined $sf).
Created attachment 38485 [details] [review] Bug 14061: Fix broken mapping for not withdrawn items. TEST PLAN --------- 1) Run inventory on a filtered set such that the selected barcode is not withdrawn. -- the Withdrawn column displays '0'. 2) Apply patch 3) Rerun -- the Withdrawn column displays '' (as expected) 4) run koha qa test tools
Created attachment 38486 [details] statuses say 0 It's not just withdrawn that shows 0 by the way ... it's all status columns
Also, after applying the patch I still see 0 ...
Created attachment 38487 [details] after patch I still see 0 after patch.
Please post a screen shot of your authorized values for WITHDRAWN. If there is no mapping for WITHDRAWN=0, then it will still show 0.
Created attachment 38488 [details] authorized values on first test I didn't have a zero
Created attachment 38489 [details] authorized values on second test I added a 0 with no description
Created attachment 38490 [details] withdrawn cataloging with the 0 value I get a 0 in my withdrawn pull down when cataloging now ...
Created attachment 38491 [details] limit to withdrawn with patch With the patch when I limit to withdrawn I get a 1 instead of the word 'withdrawn'
Created attachment 38493 [details] [review] Bug 14061: Fix broken mapping for not withdrawn items. TEST PLAN --------- 1) Check what values to have entered for WITHDRAWN authorized values (Home -> Koha Administration -> Authorized values change dropdown to WITHDRAWN) 2) Add a new authorized value of 0 () if one is missing. 3) Add a new authorized value of 1 (Withdrawn) if one is missing. 4) Run inventory on a filtered set such that the selected barcode is not withdrawn. (Home -> Tools -> Inventory/stocktaking) -- the Withdrawn column displays '0'. 5) Run inventory on a filtered set such that the selected barcode is withdrawn. -- the Withdrawn column displays '1'. 6) Apply patch 7) Rerun steps 4 & 5 -- the Withdrawn column displays the descriptions as seen in steps 1-3. 8) run koha qa test tools
I'm doing a fresh base install to see if I can replicate your failures, because I can't on my current system.
Painfully, I redid a fresh install on Ubuntu 14.04 LTS a full git install from scratch. I ran it without the patch Withdrawn = 0 in the table (as is all the fields beside Withdrawn). I then ran it with the patch. Everything was still 0. I then checked my authorised values, and there was no 0, so I added it 'Not Withdrawn'. Re-ran, and 'Not Withdrawn' is displayed now. I figured I'd check it out. Then re-run, I got a nice yellow warning telling me it checked it back in. So, I re-ran it again, and got 'Not Withdrawn'. Nicole, I think your settings are a-typical or something. I'm going to put this back to 'Needs Signoff' and perhaps someone else with be able to duplicate the issue with the... test plan in comment #10.
Created attachment 38505 [details] [review] [Signed-off] Bug 14061: Fix broken mapping for not withdrawn items. TEST PLAN --------- 1) Check what values to have entered for WITHDRAWN authorized values (Home -> Koha Administration -> Authorized values change dropdown to WITHDRAWN) 2) Add a new authorized value of 0 () if one is missing. 3) Add a new authorized value of 1 (Withdrawn) if one is missing. 4) Run inventory on a filtered set such that the selected barcode is not withdrawn. (Home -> Tools -> Inventory/stocktaking) -- the Withdrawn column displays '0'. 5) Run inventory on a filtered set such that the selected barcode is withdrawn. -- the Withdrawn column displays '1'. 6) Apply patch 7) Rerun steps 4 & 5 -- the Withdrawn column displays the descriptions as seen in steps 1-3. 8) run koha qa test tools Followed test plan #1-#7. Aut. value for 0 set to: 'No' amd 1: "withdrawn'. Works as expected. Signed-off-by: Marc Véron <veron@veron.ch>
Created attachment 38735 [details] [review] [PASSED QA] Bug 14061: Fix broken mapping for not withdrawn items. TEST PLAN --------- 1) Check what values to have entered for WITHDRAWN authorized values (Home -> Koha Administration -> Authorized values change dropdown to WITHDRAWN) 2) Add a new authorized value of 0 () if one is missing. 3) Add a new authorized value of 1 (Withdrawn) if one is missing. 4) Run inventory on a filtered set such that the selected barcode is not withdrawn. (Home -> Tools -> Inventory/stocktaking) -- the Withdrawn column displays '0'. 5) Run inventory on a filtered set such that the selected barcode is withdrawn. -- the Withdrawn column displays '1'. 6) Apply patch 7) Rerun steps 4 & 5 -- the Withdrawn column displays the descriptions as seen in steps 1-3. 8) run koha qa test tools Followed test plan #1-#7. Aut. value for 0 set to: 'No' amd 1: "withdrawn'. Works as expected. Signed-off-by: Marc Veron <veron@veron.ch> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Because Bug 14057 was pushed to master, this bug is invalid.