On jessie, doing a zebra reindex will cause errors like: 15:10:47-01/05 zebraidx(16108) [warn] No such record type: dom./etc/koha/zebradb/biblios/etc/dom-config.xml A workaround is documented here: http://wiki.koha-community.org/wiki/Troubleshooting_Zebra#No_such_record_type However we need to get it working out of the box, and to be backwards compatible. My plan is: * have koha-start-zebra check for the location of mod-dom.so, probably searching through a predefined list. * have it create a symlink inside /var/lib/koha that points to the right directory for the libraries. * update the zebra*.cfg templates so that they point to the new symlink location * as part of postinst, update the configuration for currently installed files so that they point to the symlink location. This'll mean that it'll work on all the layouts of the zebra libraries that we care to handle.
Created attachment 39356 [details] [review] Bug 14106: koha-start-zebra ensures a correct link exists When koha-start-zebra starts, it first checks to see if there is a symlink (/var/lib/koha/zebramodules) pointing to the location that contains the zebra modules. If not, it makes one. It will also remove and replace incorrect ones. Testing: * Run koha-start-zebra, see that /var/lib/koha/zebramodules exists and points to whatever directory contains your zebra modules. * Run koha-start-zebra, see that nothing has changed * Delete the symlink, run koha-start-zebra, see that it puts it back, * Make a new symlink that points to the wrong place, run koha-start-zebra, see that it replaces it with a correct one.
Comment on attachment 39356 [details] [review] Bug 14106: koha-start-zebra ensures a correct link exists Turns out this is unnecessary, we can put multiple paths directly into the zebra configuration.
Created attachment 39357 [details] [review] Bug 14106: fill up the zebra config with a list of modulePaths This adds the full list of paths that debian might use for zebra to the search path for modules. It also means we can say we support s390x architecture. Whatever that is.
Created attachment 39378 [details] [review] Bug 14106: patch existing zebra configs with new modulePath This patches the zebra configuration of existing Koha installations so that their modulePath will work on newer Debian (and presumably Ubuntu) releases. Testing: * Install a package built with this patch onto a system with instances created by an older Koha version. * Check that the files in /etc/koha/sites/*/zebra-*.cfg have the new modulePath: directive rather than the old one.
Created attachment 39410 [details] [review] [PASSED QA] Bug 14106: fill up the zebra config with a list of modulePaths This adds the full list of paths that debian might use for zebra to the search path for modules. It also means we can say we support s390x architecture. Whatever that is. Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
Created attachment 39411 [details] [review] [PASSED QA] Bug 14106: patch existing zebra configs with new modulePath This patches the zebra configuration of existing Koha installations so that their modulePath will work on newer Debian (and presumably Ubuntu) releases. Testing: * Install a package built with this patch onto a system with instances created by an older Koha version. * Check that the files in /etc/koha/sites/*/zebra-*.cfg have the new modulePath: directive rather than the old one. Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
Patches pushed to master. Good job Robin!
Created attachment 39429 [details] [review] Bug 14106: (QA followup) avoid failures if no instances created If there are no instances already created on install/upgrade, the koha-common.postinst script hungs in the absence of files to fix and keeps waiting for user input. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
oh, good catch on that last one. Thanks!
Marking for inclusion in 3.18.x
Patch pushed to 3.18.x will be in 3.18.08
Note to self to include "This makes Koha 3.18 compatible with Debian (Jessie)" in the release notes.
(In reply to Liz Rea from comment #12) > Note to self to include "This makes Koha 3.18 compatible with Debian > (Jessie)" in the release notes. curious, would this be a problem in 3.16.x too?
(In reply to Mason James from comment #13) > (In reply to Liz Rea from comment #12) > > Note to self to include "This makes Koha 3.18 compatible with Debian > > (Jessie)" in the release notes. > > curious, would this be a problem in 3.16.x too? Yep.
Created attachment 43886 [details] [review] Bug 14106: (RM followup) sick of failing tests in Jessie This patch adds the original fix for source installs too... Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>