Noted: bug 8879 is an omnibus for the ./t errors. This cleanly catches all the errors in t/00-load.t, but it does not clean up the Koha tests which actually exclude testing Koha/NorwegianPatronDB.pm!
Created attachment 38751 [details] [review] Bug 14110: Silence t/00-load.t warnings prove t/00-load.t has noisy messages. This catches them. TEST PLAN --------- 1) $ prove -v t/00-load.t -- ugly INIT errors, etc. 2) apply patch 3) $ prove -v t/00-load.t -- nice "Expected warnings" type messages on the ones that were noisy. 4) koha qa test tools
Created attachment 39226 [details] [review] Bug 14110: Silence t/00-load.t warnings prove t/00-load.t has noisy messages. This catches them. TEST PLAN --------- 1) $ prove -v t/00-load.t -- ugly INIT errors, etc. 2) apply patch 3) $ prove -v t/00-load.t -- nice "Expected warnings" type messages on the ones that were noisy. 4) koha qa test tools Signed-off-by: Indranil Das Gupta <indradg@gmail.com> Test remarks: Expected outcome as per test plan. No anomaly noted.
These warnings should not be hidden, we should fix them correctly. IMO this is not valid.
(In reply to Jonathan Druart from comment #3) > These warnings should not be hidden, we should fix them correctly. > IMO this is not valid. In which case, I would recommend three new bugs. I would recommend 4, but the hbbyy whatever it is barcode is deprecated. We should just catch that error, since there is no sense in fixing something declared deprecated.
> In which case, I would recommend three new bugs. I would recommend 4, but > the hbbyy whatever it is barcode is deprecated. We should just catch that > error, since there is no sense in fixing something declared deprecated. Hm, why do you think it's deprecated? <branchcode>yymm0001 is still a valid choice for AutoBarcode.
(In reply to Katrin Fischer from comment #5) > > In which case, I would recommend three new bugs. I would recommend 4, but > > the hbbyy whatever it is barcode is deprecated. We should just catch that > > error, since there is no sense in fixing something declared deprecated. > > Hm, why do you think it's deprecated? <branchcode>yymm0001 is still a valid > choice for AutoBarcode. perldoc C4/Barcodes/hbyymmincr.pm Comment from 2008 by Joe Atzberger.
Hi Mark, I see... but I am not sure this is enough to deprecate as probably noone remembers it and no steps have been taken to remove the format from new installation or mark it as deprecated. I have my doubts about treating it as deprecated.
I think this bug is best suited for the DBIx Mock related warnings, as the INIT warnings currently in t/00-load.t have been dealt with in bug 16635, bug 16636, and bug 16637.
I ran prove -v t/00-load.t on master and it's all green and without any warnings or errors.