Bug 14134 - Make "Holds over" show holds expiring tomorrow if ExpireReservesMaxPickUpDelay is set
Summary: Make "Holds over" show holds expiring tomorrow if ExpireReservesMaxPickUpDela...
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Hold requests (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Kyle M Hall
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-05-04 11:58 UTC by Kyle M Hall
Modified: 2017-06-14 22:07 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 14134 - Make "Holds over" show holds expiring tomorrow if ExpireReservesMaxPickUpDelay is set (3.46 KB, patch)
2015-05-04 12:00 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 14134 - Make "Holds over" show holds expiring tomorrow if ExpireReservesMaxPickUpDelay is set (3.46 KB, patch)
2015-05-04 12:35 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 14134 - Make "Holds over" show holds expiring tomorrow if ExpireReservesMaxPickUpDelay is set (3.58 KB, patch)
2015-12-04 19:22 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 14134 - Make "Holds over" show holds expiring tomorrow if ExpireReservesMaxPickUpDelay is set (3.66 KB, patch)
2016-02-02 12:31 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Kyle M Hall 2015-05-04 11:58:04 UTC
If ExpireReservesMaxPickUpDelay is enabled, the "holds over" tab becomes useless. It would be nice if the "holds over" tab would display *tomorrow's* "holds over" so the librarian can see what will be automatically canceled over night.
Comment 1 Kyle M Hall 2015-05-04 12:00:25 UTC Comment hidden (obsolete)
Comment 2 Kyle M Hall 2015-05-04 12:35:33 UTC Comment hidden (obsolete)
Comment 3 Kyle M Hall 2015-12-04 19:22:06 UTC Comment hidden (obsolete)
Comment 4 Jonathan Druart 2016-02-02 12:31:36 UTC
Created attachment 47550 [details] [review]
Bug 14134 - Make "Holds over" show holds expiring tomorrow if ExpireReservesMaxPickUpDelay is set

If ExpireReservesMaxPickUpDelay is enabled, the "holds over" tab becomes
useless. It would be nice if the "holds over" tab would display
*tomorrow's* "holds over" so the librarian can see what will be
automatically canceled over night.

Test Plan:
1) Apply this patch
2) Enable ExpireReservesMaxPickUpDelay
3) Note the "holds over" list now displays holds that will have been
   waiting more than the number of days defined in ReservesMaxPickUpDelay
   as of tomorrow.

Signed-off-by: Jason Burds <JBurds@dubuque.lib.ia.us>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 5 Brendan Gallagher 2016-03-02 04:53:44 UTC
Pushed to Master - Should be in the May 2016 Release. Thanks