Bug 14137 - Allow ExpireReservesMaxPickUpDelayCharge to be used without ExpireReservesMaxPickUpDelay
Summary: Allow ExpireReservesMaxPickUpDelayCharge to be used without ExpireReservesMax...
Status: RESOLVED DUPLICATE of bug 15561
Alias: None
Product: Koha
Classification: Unclassified
Component: Hold requests (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Kyle M Hall
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-05-04 13:33 UTC by Kyle M Hall
Modified: 2016-01-12 17:48 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 14137 - Allow ExpireReservesMaxPickUpDelayCharge to be used without ExpireReservesMaxPickUpDelay (4.05 KB, patch)
2015-05-04 13:34 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 14137 - Allow ExpireReservesMaxPickUpDelayCharge to be used without ExpireReservesMaxPickUpDelay (3.28 KB, patch)
2015-12-04 19:25 UTC, Kyle M Hall
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Kyle M Hall 2015-05-04 13:33:20 UTC
Some libraries would like to be able to use ExpireReservesMaxPickUpDelayCharge without ExpireReservesMaxPickUpDelay.

ExpireReservesMaxPickUpDelay automatically cancels the holds but some librarians would prefer to cancel the holds manually but still have the patron's charged the fee for allowing a waiting hold to become expired and canceled.
Comment 1 Kyle M Hall 2015-05-04 13:34:42 UTC Comment hidden (obsolete)
Comment 2 Kyle M Hall 2015-12-04 19:25:24 UTC
Created attachment 45421 [details] [review]
Bug 14137 - Allow ExpireReservesMaxPickUpDelayCharge to be used without ExpireReservesMaxPickUpDelay

Some libraries would like to be able to use
ExpireReservesMaxPickUpDelayCharge without ExpireReservesMaxPickUpDelay.

ExpireReservesMaxPickUpDelay automatically cancels the holds but some
librarians would prefer to cancel the holds manually but still have the
patron's charged the fee for allowing a waiting hold to become expired
and canceled.

Test Plan:
1) Apply this patch
2) Set a fee amount in ExpireReservesMaxPickUpDelayCharge
3) Cancel a hold from the "holds over" tab
4) View the patron record, note the fee has been added

Signed-off-by: Jason Burds <JBurds@dubuque.lib.ia.us>
Comment 3 Jonathan Druart 2016-01-06 14:39:18 UTC
Please provide tests.
Comment 4 Kyle M Hall 2016-01-12 17:38:08 UTC
In light of bug 14464 I'm going to close this bug and open a new one with a tighter scope that will accomplish what our librarians are requesting.

*** This bug has been marked as a duplicate of bug 15561 ***