Some libraries would like to be able to use ExpireReservesMaxPickUpDelayCharge without ExpireReservesMaxPickUpDelay. ExpireReservesMaxPickUpDelay automatically cancels the holds but some librarians would prefer to cancel the holds manually but still have the patron's charged the fee for allowing a waiting hold to become expired and canceled.
Created attachment 38815 [details] [review] Bug 14137 - Allow ExpireReservesMaxPickUpDelayCharge to be used without ExpireReservesMaxPickUpDelay Some libraries would like to be able to use ExpireReservesMaxPickUpDelayCharge without ExpireReservesMaxPickUpDelay. ExpireReservesMaxPickUpDelay automatically cancels the holds but some librarians would prefer to cancel the holds manually but still have the patron's charged the fee for allowing a waiting hold to become expired and canceled. Test Plan: 1) Apply this patch 2) Set a fee amount in ExpireReservesMaxPickUpDelayCharge 3) Cancel a hold from the "holds over" tab 4) View the patron record, note the fee has been added
Created attachment 45421 [details] [review] Bug 14137 - Allow ExpireReservesMaxPickUpDelayCharge to be used without ExpireReservesMaxPickUpDelay Some libraries would like to be able to use ExpireReservesMaxPickUpDelayCharge without ExpireReservesMaxPickUpDelay. ExpireReservesMaxPickUpDelay automatically cancels the holds but some librarians would prefer to cancel the holds manually but still have the patron's charged the fee for allowing a waiting hold to become expired and canceled. Test Plan: 1) Apply this patch 2) Set a fee amount in ExpireReservesMaxPickUpDelayCharge 3) Cancel a hold from the "holds over" tab 4) View the patron record, note the fee has been added Signed-off-by: Jason Burds <JBurds@dubuque.lib.ia.us>
Please provide tests.
In light of bug 14464 I'm going to close this bug and open a new one with a tighter scope that will accomplish what our librarians are requesting. *** This bug has been marked as a duplicate of bug 15561 ***