When Bug 12820 was added to Koha 3.18, the namespace was not altered. This causes checkouts to fail via SIP2.
Created attachment 38872 [details] [review] Bug 14151 - SIP2 Checkouts file in Koha 3.18 When Bug 12820 was added to Koha 3.18, the namespace was not altered. This causes checkouts to fail via SIP2. Test Plan: 1) Attempt to check out an item via SIP2 2) Note you never get back a response 3) Apply this patch 4) Repeat step 1 5) Note it now works!
Created attachment 39273 [details] [review] Bug 14151 - SIP2 Checkouts file in Koha 3.18 When Bug 12820 was added to Koha 3.18, the namespace was not altered. This causes checkouts to fail via SIP2. Test Plan: 1) Attempt to check out an item via SIP2 2) Note you never get back a response 3) Apply this patch 4) Repeat step 1 5) Note it now works! Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
i'll test this bug on 3.16.x too
I tried testing this on 3.18.x, but I had problems with the telnet connection - can someone else give this a try please?
Problem arises because patch for bug 7904 had not been applied in 3.18 and 12820 assumed it had reverting to old libpath fixes this
Hi Colin, is this a fail for the patch or a pass? Sorry, still confused! Can you please switch the status accordingly?
From my understanding.. we could either push this patch to fix it in 3.18... or apply bug 7904 to fix the same issue.. It's either end of the same problem.
Can someone confirm that bug 7904 applies on 3.18.x and would solve this problem please?
Maybe I missed something, but it does not work here: % perl -IC4/SIP/ -MILS C4/SIP/SIPServer.pm /home/koha/etc/SIPconfig.xml Can't locate object method "new" via package "ILS::Patron" (perhaps you forgot to load "ILS::Patron"?) at C4/SIP/ILS.pm line 134.
(In reply to Katrin Fischer from comment #8) > Can someone confirm that bug 7904 applies on 3.18.x and would solve this > problem please? 7904 has now been applied to 3.18 (and 3.16), but, the problem still needs to be confirmed fixed for this bug
Jonathan, bit worried about this one here - does it work on master now for you? I think the idea was not to push this change, but only 7904 to fix things.
(In reply to Jonathan Druart from comment #9) > Maybe I missed something, but it does not work here: > > % perl -IC4/SIP/ -MILS C4/SIP/SIPServer.pm /home/koha/etc/SIPconfig.xml > Can't locate object method "new" via package "ILS::Patron" (perhaps you > forgot to load "ILS::Patron"?) at C4/SIP/ILS.pm line 134. Ok so forget that. Could someone confirm this can be close?
Confirmed!