Bug 14151 - SIP2 Checkouts fail in Koha 3.18
Summary: SIP2 Checkouts fail in Koha 3.18
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: SIP2 (show other bugs)
Version: 3.18
Hardware: All All
: P5 - low critical (vote)
Assignee: Kyle M Hall
QA Contact: Colin Campbell
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-05-05 18:19 UTC by Kyle M Hall
Modified: 2019-06-27 09:24 UTC (History)
7 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 14151 - SIP2 Checkouts file in Koha 3.18 (1.07 KB, patch)
2015-05-05 18:21 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 14151 - SIP2 Checkouts file in Koha 3.18 (1.12 KB, patch)
2015-05-18 05:07 UTC, Chris Cormack
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Kyle M Hall 2015-05-05 18:19:55 UTC
When Bug 12820 was added to Koha 3.18, the namespace was not altered. This causes checkouts to fail via SIP2.
Comment 1 Kyle M Hall 2015-05-05 18:21:22 UTC Comment hidden (obsolete)
Comment 2 Chris Cormack 2015-05-18 05:07:14 UTC
Created attachment 39273 [details] [review]
Bug 14151 - SIP2 Checkouts file in Koha 3.18

When Bug 12820 was added to Koha 3.18, the namespace was not altered.
This causes checkouts to fail via SIP2.

Test Plan:
1) Attempt to check out an item via SIP2
2) Note you never get back a response
3) Apply this patch
4) Repeat step 1
5) Note it now works!

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Comment 3 Mason James 2015-05-18 22:47:46 UTC
i'll test this bug on 3.16.x too
Comment 4 Katrin Fischer 2015-05-18 22:51:37 UTC
I tried testing this on 3.18.x, but I had problems with the telnet connection - can someone else give this a try please?
Comment 5 Colin Campbell 2015-05-20 11:39:02 UTC
Problem arises because patch for bug 7904 had not been applied in 3.18 and 12820 assumed it had reverting to old libpath fixes this
Comment 6 Katrin Fischer 2015-05-20 11:55:09 UTC
Hi Colin, is this a fail for the patch or a pass? Sorry, still confused! Can you please switch the status accordingly?
Comment 7 Martin Renvoize 2015-05-20 12:04:22 UTC
From my understanding.. we could either push this patch to fix it in 3.18... or apply bug 7904 to fix the same issue..  It's either end of the same problem.
Comment 8 Katrin Fischer 2015-05-20 15:06:40 UTC
Can someone confirm that bug 7904 applies on 3.18.x and would solve this problem please?
Comment 9 Jonathan Druart 2015-05-27 16:50:50 UTC
Maybe I missed something, but it does not work here:

% perl -IC4/SIP/ -MILS C4/SIP/SIPServer.pm /home/koha/etc/SIPconfig.xml
Can't locate object method "new" via package "ILS::Patron" (perhaps you forgot to load "ILS::Patron"?) at C4/SIP/ILS.pm line 134.
Comment 10 Mason James 2015-05-27 22:41:47 UTC
(In reply to Katrin Fischer from comment #8)
> Can someone confirm that bug 7904 applies on 3.18.x and would solve this
> problem please?

7904 has now been applied to 3.18 (and 3.16), 

but, the problem still needs to be confirmed fixed for this bug
Comment 11 Katrin Fischer 2015-05-31 12:30:52 UTC
Jonathan, bit worried about this one here - does it work on master now for you? I think the idea was not to push this change, but only 7904 to fix things.
Comment 12 Jonathan Druart 2015-06-03 10:12:52 UTC
(In reply to Jonathan Druart from comment #9)
> Maybe I missed something, but it does not work here:
> 
> % perl -IC4/SIP/ -MILS C4/SIP/SIPServer.pm /home/koha/etc/SIPconfig.xml
> Can't locate object method "new" via package "ILS::Patron" (perhaps you
> forgot to load "ILS::Patron"?) at C4/SIP/ILS.pm line 134.

Ok so forget that.
Could someone confirm this can be close?
Comment 13 Kyle M Hall 2015-07-06 16:15:06 UTC
Confirmed!