There is currently a bug with the stage-marc-import.pl when the plugins are disabled. It raises a "Internal server error" page. I noticed that Koha_Master_U14 (the task on jenkins that runs the mentioned test) just hangs waiting for output of the test. This should be fixed. To reproduce: - Checkout 4e0468e8c2587fa4f51cb22b59ac5466383bbab1 (a commit without the fix for the specific problem that raises the test problem). - Set the environment for running the test: export KOHA_USER=kohaadmin export KOHA_PASS=katikoan export KOHA_INTRANET_URL="<paste your intranet url>" export KOHA_OPAC_URL="<paste your opac url>" - Run the test: prove t/db_dependent/www/search_utf8.t => FAIL: You will see something like this on the output while the test just hangs: t/db_dependent/www/search_utf8.t .. 3/64 Error GETing http://koha-dev.biblioadmin/cgi-bin/koha/tools/stage-marc-import.pl: Internal Server Error at t/db_dependent/www/search_utf8.t line 127. # Looks like you planned 64 tests but ran 4. # Looks like your test exited with 255 just after 4. and the prompt is not released. At all.
There should be (at least) a reasonable timeout.
Created attachment 49676 [details] [review] Bug 14158: www search tests - Cleanup at the end When something wrong happen, the parent process is waiting for the children to finish, but they have been zombified and the test hangs. To fix that, we should ensure that the cleanup is correctly done and that the processes are correctly killed. Test plan: export KOHA_USER=koha export KOHA_PASS=koha export KOHA_INTRANET_URL=http://do_not_exist_but_its_expected export KOHA_OPAC_URL=http://another_url prove t/db_dependent/www/search_utf8.t Without this patch, the tests will hang With the patch applied, they won't!
Created attachment 49684 [details] [review] Bug 14158: www search tests - Cleanup at the end When something wrong happen, the parent process is waiting for the children to finish, but they have been zombified and the test hangs. To fix that, we should ensure that the cleanup is correctly done and that the processes are correctly killed. Test plan: export KOHA_USER=koha export KOHA_PASS=koha export KOHA_INTRANET_URL=http://do_not_exist_but_its_expected export KOHA_OPAC_URL=http://another_url prove t/db_dependent/www/search_utf8.t Without this patch, the tests will hang With the patch applied, they won't! Signed-off-by: Tomas Cohen Arazi <tomascohen@unc.edu.ar>
QAing as it is a trivial test fix no one has cared about yet :-D
Pushed to Master - Should be in the May 2016 release. Thanks!
Patch pushed to 3.22.x, will be in 3.22.6
Pushed to 3.20.x, will be in 3.20.11.